Fix TOML encoder to quote keys containing special characters#2648
Draft
Fix TOML encoder to quote keys containing special characters#2648
Conversation
Agent-Logs-Url: https://github.com/mikefarah/yq/sessions/b2b52954-d13f-4e67-831a-16fdd3378de5 Co-authored-by: mikefarah <1151925+mikefarah@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix parsing failure for toml files with special characters
Fix TOML encoder to quote keys containing special characters
Apr 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TOML bare keys are restricted to
[A-Za-z0-9_-]. The encoder was emitting keys likehttp://sealos.hub:5000or/tmp/blahunquoted, producing invalid TOML that failed to re-parse.Changes
encoder_toml.go: Added two helpers:tomlKey(key)— returns key unchanged if it's a valid bare key, otherwise wraps it with%qtomlDottedKey(path)— joins path segments for table/array-of-tables headers, quoting each segment as needed[[array-of-tables]]headers, and[table]section headersExample
Before (invalid TOML):
After (valid, re-parseable TOML):