Repository navigation
chore: simplify tooling to oxlint + tsc #378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
8b79f0a
chore: simplify tooling to oxlint + tsc
claude 13cd04c
chore(zed): use the same settings as standard-server
claude 865f91b
chore(tsconfig): drop allowImportingTsExtensions and resolveJsonModule
claude a404ac3
chore: build packages in CI, drop a disable directive for a rule that…
claude f7124f7
chore(tsconfig): don't list package.json in tsconfig.lib.json include
claude db13d10
ci: publish PR previews with pkg-pr-new instead of running prepack in…
claude a908fbd
chore: don't lint or format agent skills
claude bb3dac1
chore: add sherif back as `pnpm repo:fix`
claude b45e791
chore(dependabot): group minor and patch dev-dependency updates
claude 1bbf47f
docs(agents): use `pnpm exec sherif` in CI, where sherif refuses to fix
claude f37b112
docs(agents): mention repo:fix only in the command list
claude File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Empty file.
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -7,6 +7,7 @@ | |
| !.github/ | ||
| !.vitepress/ | ||
| !.claude/ | ||
| .claude/worktrees/ | ||
| !.agents/ | ||
| !.zed/ | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| { | ||
| "recommendations": ["oxc.oxc-vscode"] | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| { | ||
| "editor.defaultFormatter": "oxc.oxc-vscode", | ||
| "editor.formatOnSave": true, | ||
| "editor.codeActionsOnSave": { | ||
| "source.fixAll.oxc": "explicit" | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,24 +1,4 @@ | ||
| { | ||
| "format_on_save": "on", | ||
| "formatter": { | ||
| "external": { | ||
| "command": "./node_modules/.bin/oxfmt", | ||
| "arguments": ["--stdin-filepath", "{buffer_path}"] | ||
| } | ||
| }, | ||
| // Apply oxlint's auto fixes on save: | ||
| "code_actions_on_format": { | ||
| "source.fixAll.oxc": true | ||
| }, | ||
| "lsp": { | ||
| "typescript-language-server": { | ||
| "settings": { | ||
| "typescript": { | ||
| "preferences": { | ||
| "includePackageJsonAutoImports": "on" | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
| "formatter": [{ "code_action": "source.fixAll.oxc" }, { "language_server": { "name": "oxfmt" } }] | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| # AGENTS.md | ||
|
|
||
| ## Repository | ||
|
|
||
| OpenAPI Spec: OpenAPI types and tools, in a pnpm monorepo. | ||
|
|
||
| - `packages/*`: the published packages, each with `src`, and `tests` and `benches` where it has them | ||
| - `scripts/`: repository scripts | ||
|
|
||
| ## Commands | ||
|
|
||
| ```bash | ||
| pnpm install | ||
| pnpm test # vitest | ||
| pnpm vitest run <path> # one test file | ||
| pnpm check # lint and type check, including *.test-d.ts | ||
| pnpm fix # check, applying fixes | ||
| pnpm format # format with oxfmt | ||
| pnpm repo:fix # fix monorepo issues (sherif) | ||
| pnpm bench | ||
| pnpm --filter @openapi-spec/downgrader prepack # build one package; tests don't need a build | ||
| ``` | ||
|
|
||
| Before finishing, run `pnpm format`, `pnpm check` and `pnpm test`. CI doesn't check formatting. | ||
|
|
||
| ## Pull requests | ||
|
|
||
| Titles follow Conventional Commits, scoped by the affected packages, separated by a comma and a space: `fix(downgrader): ...`, `fix(downgrader, router): ...`. Leave out the scope when the change is too broad. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,9 @@ | ||
| import { defineConfig } from 'oxfmt' | ||
| import { middleapi } from 'uncheck/oxfmt' | ||
|
|
||
| export default defineConfig({ | ||
| ...middleapi, | ||
| ignorePatterns: ['.agents/skills/**', '.claude/skills/**'], | ||
| semi: false, | ||
| singleQuote: true, | ||
| quoteProps: 'consistent', | ||
| sortImports: true, | ||
| }) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,2 +1,2 @@ | ||
| export { downgradeSchemaV31ToV30, downgradeSpecV31ToV30 } from './v3.1-to-v3.0' | ||
| export { downgradeSchemaV32ToV31, downgradeSpecV32ToV31 } from './v3.2-to-v3.1' | ||
| export { downgradeSchemaV31ToV30, downgradeSpecV31ToV30 } from './v3.1-to-v3.0.ts' | ||
| export { downgradeSchemaV32ToV31, downgradeSpecV32ToV31 } from './v3.2-to-v3.1.ts' |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.