feat: add running model path / model precision to perf output#875
Open
xieofxie wants to merge 3 commits into
Open
feat: add running model path / model precision to perf output#875xieofxie wants to merge 3 commits into
xieofxie wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #81.
The
perfJSON report did not record which ONNX model was actually run, so users had no way to locate the built/compiled model on disk (issue #81, question 1). This adds the real running model path — the ONNX file ORT actually loads, which can differ from the inputmodel_id/onnx_pathwhen an EPContext (compiled) model is produced or a cached one is reused.benchmark_infonow includesrunning_model_path:Changes
session/session.py: track the resolved model path ORT loads via a newrunning_model_pathproperty (set incompile(); falls back to the input path before compilation).session/qairt/qairt_session.py: record the EPContext path the QAIRT session loads.models/winml/base.py: exposerunning_model_pathon the model, delegating to the session.commands/perf.py: emitrunning_model_pathinbenchmark_info, and add it to each per-module instance entry in--modulemode.Tests
tests/e2e/test_perf_e2e.py::test_benchmark_cputo assertrunning_model_pathis an existing.onnxfile.-m e2e):test_benchmark_cpuandtest_module_benchmark_cpupass;tests/unit/commands/test_perf_cli.py(28) passes.🤖 Generated with Claude Code
@