Skip to content

Add Mission Planner manifest - #8521

Closed
Huldar (G0rocks) wants to merge 20 commits into
microsoft:masterfrom
G0rocks:master
Closed

Add Mission Planner manifest#8521
Huldar (G0rocks) wants to merge 20 commits into
microsoft:masterfrom
G0rocks:master

Conversation

@G0rocks

@G0rocks Huldar (G0rocks) commented Mar 9, 2021

Copy link
Copy Markdown
Contributor
  • Have you signed the Contributor License Agreement?
  • [ x] Have you checked that there aren't other open pull requests for the same manifest update/change?
  • [ x] Have you validated your manifest locally with winget validate <manifest>, where <manifest> is the name of the manifest you're submitting?
  • Have you tested your manifest locally with winget install -m <manifest>?

I had problems testing the manifest locally, could somebody help me out?
I got this error message:
winget-pkgs\manifests\Ardupilot\MissionPlanner>winget install -m 1.3.72.yaml Found Mission Planner [Mission.Planner] This application is licensed to you by its owner. Microsoft is not responsible for, nor does it grant any licences to, third-party packages. Downloading https://firmware.ardupilot.org/Tools/MissionPlanner/MissionPlanner-latest.msi An unexpected error occurred while executing the command: InternetOpenUrl() failed. 0x80072f19 : unknown error

Microsoft Reviewers: Open in CodeFlow

@wingetbot

Copy link
Copy Markdown
Collaborator

/AzurePipelines run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot (wingetbot) added the Manifest-Validation-Error Manifest validation failed label Mar 9, 2021
@ghost

Copy link
Copy Markdown

G0rocks The package manager bot determined that the metadata was not compliant. Make sure the ID is of the form publisher.appname and that the folder structure is publisher\appname. Be sure to use a tool like VSCode (https://code.visualstudio.com/) to make sure your request is YAML syntax is correct. Please also verify the manifest file is compliant with the package manager specification (https://docs.microsoft.com/windows/package-manager/package)
For details on the error, see the details link below in the build pipeline.

@G0rocks

Copy link
Copy Markdown
Contributor Author

Here is an issue where other people are having the same problem as me:
microsoft/winget-cli#417

@ghost ghost removed Manifest-Validation-Error Manifest validation failed Needs: Attention labels Mar 9, 2021
@wingetbot

Copy link
Copy Markdown
Collaborator

/AzurePipelines run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot (wingetbot) added the Manifest-Validation-Error Manifest validation failed label Mar 9, 2021
@ghost

Copy link
Copy Markdown

G0rocks The package manager bot determined that the metadata was not compliant. Make sure the ID is of the form publisher.appname and that the folder structure is publisher\appname. Be sure to use a tool like VSCode (https://code.visualstudio.com/) to make sure your request is YAML syntax is correct. Please also verify the manifest file is compliant with the package manager specification (https://docs.microsoft.com/windows/package-manager/package)
For details on the error, see the details link below in the build pipeline.

@ghost ghost added Needs: Attention and removed Needs: author feedback Manifest-Validation-Error Manifest validation failed labels Mar 9, 2021
@wingetbot

Copy link
Copy Markdown
Collaborator

/AzurePipelines run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot (wingetbot) added the Manifest-Validation-Error Manifest validation failed label Mar 9, 2021
@ghost

Copy link
Copy Markdown

G0rocks The package manager bot determined that the metadata was not compliant. Make sure the ID is of the form publisher.appname and that the folder structure is publisher\appname. Be sure to use a tool like VSCode (https://code.visualstudio.com/) to make sure your request is YAML syntax is correct. Please also verify the manifest file is compliant with the package manager specification (https://docs.microsoft.com/windows/package-manager/package)
For details on the error, see the details link below in the build pipeline.

@G0rocks

Copy link
Copy Markdown
Contributor Author

I have now successfully cleared all tests required

@ghost ghost removed the Manifest-Validation-Error Manifest validation failed label Mar 9, 2021
@ghost

Copy link
Copy Markdown

Huldar (@G0rocks) I am sorry to report that the Sha256 Hash does not match the installer. This maybe caused by using a vanity URL rather than a URL directly to the binary.

Please check the HASH and submit again. Sorry for the inconvenience.

- Architecture: "x64"
InstallerType: "msi"
InstallerUrl: "https://firmware.ardupilot.org/Tools/MissionPlanner/MissionPlanner-latest.msi"
InstallerSha256: f9401a1857c447ef59769ef33414c4df4dd71ec9d90523e632a483cec60e529e

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1eb59aef23977a0d6b1a493160667649d009160755e90a27843af3e6f140b75a

@wingetbot

Copy link
Copy Markdown
Collaborator

/AzurePipelines run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot

Copy link
Copy Markdown
Collaborator

/AzurePipelines run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@G0rocks

Copy link
Copy Markdown
Contributor Author

So it says installer validation failed but it works on my end. Using the hash from denelon ¯_(ツ)_/¯

@G0rocks

Copy link
Copy Markdown
Contributor Author

I think working on this is pointless until this issue is resolved, which I don't know how to do, or until winget can install with installers that don't install silently. So just going to take a break

Huldar (G0rocks) and others added 7 commits February 16, 2022 13:08
…S.yaml

Co-authored-by: Levvie - she/her <11600822+ItzLevvie@users.noreply.github.com>
…S.yaml

Co-authored-by: Levvie - she/her <11600822+ItzLevvie@users.noreply.github.com>
Co-authored-by: Levvie - she/her <11600822+ItzLevvie@users.noreply.github.com>
Co-authored-by: Levvie - she/her <11600822+ItzLevvie@users.noreply.github.com>
Co-authored-by: Levvie - she/her <11600822+ItzLevvie@users.noreply.github.com>
…2b8b5-2b73-45a1-afa6-cc9200426e1c

Autogenerated/kitware.para view/3ab2b8b5 2b73 45a1 afa6 cc9200426e1c
@wingetbot

Copy link
Copy Markdown
Collaborator

/AzurePipelines run

@azure-pipelines

Copy link
Copy Markdown

No commit pushedDate could be found for PR 8521 in repo microsoft/winget-pkgs

@wingetbot

Copy link
Copy Markdown
Collaborator

/AzurePipelines run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@ghost

Copy link
Copy Markdown

Hello Huldar (@G0rocks),
The package manager bot determined there was an issue with the pull request. Make sure the manifest files are under the manifests\partition\publisher\appname\version directory. The partition of the path must be the first letter of the publisher in lower-case.

Example:
Path: manifests / m / Microsoft / WindowsTerminal / 1.6.10571.0 / WindowsTerminal.yaml

For details on the error, see the details link below in the build pipeline.

You may also try the Windows Package Manager Manifest Creator

@denelon

Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@ghost

Copy link
Copy Markdown

Hello Huldar (@G0rocks),
The package manager bot determined there was an issue with the pull request. Make sure the manifest files are under the manifests\partition\publisher\appname\version directory. The partition of the path must be the first letter of the publisher in lower-case.

Example:
Path: manifests / m / Microsoft / WindowsTerminal / 1.6.10571.0 / WindowsTerminal.yaml

For details on the error, see the details link below in the build pipeline.

You may also try the Windows Package Manager Manifest Creator

@denelon

Copy link
Copy Markdown
Collaborator

Huldar (@G0rocks) can you rebase to see if that fixes the Pull Request error?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@ItzLevvie

Copy link
Copy Markdown
Contributor

cc Huldar (@G0rocks)

@ghost

Copy link
Copy Markdown

Hello Huldar (@G0rocks),
This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 7 days. It will be closed if no further activity occurs within 7 days of this comment.

@G0rocks

Copy link
Copy Markdown
Contributor Author

I am just going to try again from here:
#432539
Set it up from scratch, this time with komac

Thanks :)

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area-External Needs-Attention This work item needs to be reviewed by a member of the core team. PullRequest-Error PR is Invalid

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants