sessions: fix compact view state transitions - #336184
Open
Sandeep Somavarapu (sandy081) wants to merge 1 commit into
Open
Sandeep Somavarapu (sandy081) wants to merge 1 commit into
Sandeep Somavarapu (sandy081) wants to merge 1 commit into
Conversation
Keep secondary metadata hidden when the list does not own keyboard focus and rerender compact presentation across phone layout changes.\n\nCo-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot started reviewing on behalf of
Sandeep Somavarapu (sandy081)
September 14, 2026 18:21
View session
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The responsive handler reads stale DOM layout state, so production transitions remain incorrectly rendered.
Get a fresh assessment by requesting another Copilot review.
Review tier: Balanced
Findings: 1
Open findings (1)
What changed in this PR
Fixes compact Sessions list focus and responsive-layout transitions.
Changes:
- Restricts compact metadata to hover or active list focus.
- Rerenders rows when phone layout changes.
- Adds regression tests for focus and layout transitions.
| File | Description |
|---|---|
sessionsList.css |
Corrects compact metadata visibility. |
sessionsList.ts |
Refreshes compact presentation on viewport changes. |
sessionsList.test.ts |
Adds focus and transition coverage. |
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| } | ||
| }; | ||
| updateNodeHeights(this.tree.getNode()); | ||
| this.setCompact(); |
Michael Lively (Yoyokrazy)
approved these changes
Sep 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #336169 addressing the two Copilot Code Review findings that landed after auto-merge.
Validation:
npm run typecheck-client