Open
Conversation
Contributor
Colengms
commented
May 5, 2026
Colengms
commented
- Removed the recursive includes 'reduce' feature, recursive includes would no longer be expanded, so wouldn't need to be reduced.
- Added some status strings.
- Changed didChangeCppProperties from a request to a notification.
…nto dev/coleng/cpptools_dbpop
…nto dev/coleng/cpptools_dbpop
…nto dev/coleng/cpptools_dbpop
…nto dev/coleng/cpptools_dbpop
bobbrow
approved these changes
May 5, 2026
Member
|
Are we removing |
sean-mcmanus
reviewed
May 5, 2026
Contributor
sean-mcmanus
left a comment
sean-mcmanus
left a comment
There was a problem hiding this comment.
Was workspace parsing priority also supposed to be removed or deprecated?
sean-mcmanus
reviewed
May 6, 2026
| "recursiveIncludes": { | ||
| "type": "object", | ||
| "properties": { | ||
| "reduce": { |
Contributor
There was a problem hiding this comment.
Should this be deprecated instead or before it's removed? i.e. internally it would have no effect but users won't get a settings error?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.