fix jsdoc accessibility modifiers on constructors#4227
Closed
a-tarasyuk wants to merge 0 commit into
Closed
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds conformance coverage and parser support for applying JSDoc visibility tags (@private, @protected, @public) to class constructors in JS-in-TS test fixtures.
Changes:
- Added new conformance test cases for
@privateand@protectedJSDoc tags on constructors. - Updated parser reparse logic to translate those JSDoc tags into constructor visibility modifiers.
- Added new reference baselines (types/symbols/errors) for both test cases.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| testdata/tests/cases/conformance/jsdoc/jsdocProtectedTag.ts | New conformance case: @protected constructor should error on new C() |
| testdata/tests/cases/conformance/jsdoc/jsdocPrivateTag.ts | New conformance case: @private constructor should error on new C() |
| testdata/baselines/reference/conformance/jsdocProtectedTag.types | Baseline for types output of protected-constructor case |
| testdata/baselines/reference/conformance/jsdocProtectedTag.symbols | Baseline for symbols output of protected-constructor case |
| testdata/baselines/reference/conformance/jsdocProtectedTag.errors.txt | Baseline for error output of protected-constructor case |
| testdata/baselines/reference/conformance/jsdocPrivateTag.types | Baseline for types output of private-constructor case |
| testdata/baselines/reference/conformance/jsdocPrivateTag.symbols | Baseline for symbols output of private-constructor case |
| testdata/baselines/reference/conformance/jsdocPrivateTag.errors.txt | Baseline for error output of private-constructor case |
| internal/parser/reparser.go | Teach hosted JSDoc reparsing to apply access modifiers on constructors |
| internal/ast/ast.go | Add setModifiers support for ConstructorDeclaration so reparsing can attach modifiers |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.