Skip to content

Disable hoisting in node_modules. #488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Ian Clanton-Thuon (iclanton) merged 4 commits into from
Sep 16, 2026
+72 −36
Merged

Disable hoisting in node_modules. #488

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
637ca90
Disable hoisting in `node_modules`.
iclanton Sep 16, 2026
51fb1fa
Investigate build failure caused by disabling hoisting
Copilot Sep 16, 2026
d830b97
Declare the missing `typescript` peer dependency for `@typescript-esl…
Copilot Sep 16, 2026
42cffb2
Merge pull request #1 from iclanton/copilot/investigate-failing-build…
iclanton Sep 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions common/config/rush/.npmrc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,3 +24,10 @@
#
omit-lockfile-registry-resolved=true
registry=https://packagefeedproxy.microsoft.io/npm/
always-auth=false
# No phantom dependencies allowed in this repository
# Don't hoist in common/temp/node_modules
public-hoist-pattern=
# Don't hoist in common/temp/node_modules/.pnpm/node_modules
hoist=false
hoist-pattern=
11 changes: 11 additions & 0 deletions common/config/rush/pnpm-config.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -280,6 +280,17 @@
// }
// }
// }

/**
* The ".d.ts" files in "@typescript-eslint/types" reference the "typescript" package, but the package
* does not declare a dependency on it. Because this repo disables hoisting, declaring the missing peer
* dependency here is what allows TypeScript to resolve "typescript" from inside that package.
*/
"@typescript-eslint/types": {
"peerDependencies": {
"typescript": ">=4.8.4 <6.0.0"
}
}
},

/**
Expand Down
90 changes: 54 additions & 36 deletions common/config/rush/pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading