Address remaining ReflectionOperationsTests review feedback#8197
Draft
Copilot wants to merge 3 commits into
Draft
Address remaining ReflectionOperationsTests review feedback#8197Copilot wants to merge 3 commits into
Copilot wants to merge 3 commits into
Conversation
Member
|
@copilot Fix locally please not using cloud agent |
Copilot
AI
changed the title
[WIP] Address review comments for pull request 7344
Address remaining ReflectionOperationsTests review feedback
May 13, 2026
- Update AttributeMockingHelper to recognize Type instances with MemberType == TypeInfo - Move TestableExtendedTestMethod to private nested helper Co-authored-by: Evangelink <11340282+Evangelink@users.noreply.github.com>
- Make AttributeMockingHelper private - Add explicit Type check in mock handler for class-level attributes Co-authored-by: Evangelink <11340282+Evangelink@users.noreply.github.com>
Contributor
Author
Fixed locally in commits c04604d and 022f4ca:
All changes validated with automated review and secret scanning. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug Fix
What was the bug?
This follow-up addresses the remaining review feedback on PR #7344 in
ReflectionOperationsTests. The test mock for class-level attributes only recognizedTypeInfo, while the exercised code path passesType, and the test-onlyTestableExtendedTestMethodhelper remained broader in scope than necessary.How did you fix it?
Class-level attribute mocking
AttributeMockingHelper.GetCustomAttributesNotCachedto treat anyMemberInfowithMemberType == TypeInfoas a class-level provider.Typeinstances into reflection operations.Test helper scoping
TestableExtendedTestMethodto a private nested helper insideReflectionOperationsTests.Example
Original prompt
Created from VS Code.