Skip to content

Fix misleading error message for out-of-range --retry-failed-tests-delay values#8183

Closed
Copilot wants to merge 1 commit into
mainfrom
copilot/address-review-comments
Closed

Fix misleading error message for out-of-range --retry-failed-tests-delay values#8183
Copilot wants to merge 1 commit into
mainfrom
copilot/address-review-comments

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented May 13, 2026

Bug Fix

What was the bug?

RetryFailedTestsDelayOptionInvalidArgument was the single error message for both parse failures and range violations. For syntactically valid but out-of-range inputs (e.g. 25d), the message "requires a valid time span value" was misleading — the value is valid, just too large for Task.Delay (capped at int.MaxValue ms).

How did you fix it?

Updated the error message to explicitly state the allowed range:

Option '--retry-failed-tests-delay' requires a valid time span value that is non-negative and no greater than 2147483647ms (~24.20:31:23.647) (e.g. 200, 1s, 2.5m, 1h)

Updated ExtensionResources.resx and all 13 .xlf locale translation files accordingly.

Original prompt

checkout branch from PR #7840, address all open review ocmments (reply to them when handled). Then ensure repo builds without issue (use build.cmd)

The user has attached the following file paths as relevant context:

  • .github\copilot-instructions.md

Created from VS Code.

Copilot AI review requested due to automatic review settings May 13, 2026 14:24
Copilot AI review requested due to automatic review settings May 13, 2026 14:24
Copilot AI changed the title [WIP] Fix build issues and address review comments Fix misleading error message for out-of-range --retry-failed-tests-delay values May 13, 2026
Copilot AI requested a review from Evangelink May 13, 2026 14:34
@Evangelink Evangelink closed this May 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants