Skip to content

Fix targeted message updates by dropping recipient from wire payload (#738) - #739

Open
jibin jose (jibin7jose) wants to merge 3 commits into
microsoft:mainfrom
jibin7jose:fix/targeted-update-recipient
Open

Fix targeted message updates by dropping recipient from wire payload (#738)#739
jibin jose (jibin7jose) wants to merge 3 commits into
microsoft:mainfrom
jibin7jose:fix/targeted-update-recipient

Conversation

@jibin7jose

Copy link
Copy Markdown
Contributor

Summary:

  • Route targeted ctx.send updates through updateTargetedActivity without sending recipient.
  • Add a regression test that verifies the targeted update payload omits recipient.

Fixes #738

Copilot AI lite review requested due to automatic review settings August 19, 2026 17:46

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes a Teams targeted-message update failure by ensuring targeted ctx.send updates use the targeted update endpoint while omitting recipient from the outbound update payload (since Teams rejects recipient edits on targeted-message updates).

Changes:

  • Route targeted updates (payload.id + recipient.isTargeted === true) through updateTargetedActivity with recipient removed from the wire payload.
  • Add a regression test asserting the targeted update payload omits recipient.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
packages/apps/src/activity-sender.ts Strips recipient from targeted update payloads before calling updateTargetedActivity.
packages/apps/src/activity-sender.spec.ts Adds/updates a regression test to ensure targeted update requests omit recipient.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread packages/apps/src/activity-sender.ts Outdated
Comment thread packages/apps/src/activity-sender.spec.ts
@corinagum Corina (corinagum) changed the title Fix targeted message updates dropping recipient from wire payload (#738) Fix targeted message updates by dropping recipient from wire payload (#738) Aug 21, 2026
Comment thread packages/apps/src/activity-sender.ts Outdated
Comment thread packages/apps/src/activity-sender.spec.ts

@corinagum Corina (corinagum) left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey jibin jose (@jibin7jose), thanks for the PR! I've tested this e2e to validate. I've pinged Shanmathi Mayuram Krithivasan (@ShanmathiMayuramKrithivasan) and asked her to also take a look in case there are updates we need on the wire.

teams.py has the same bug at packages/apps/src/microsoft_teams/apps/activity_send.py:43, which passes the whole activity to update_targeted_activity. teams.net is unaffected because Context.SendAsync has no update path. Would you be interested in helping out with the PY fix?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Targeted message update via ctx.send sends recipient and fails

3 participants