Resolve npm audit vulnerabilities - #732
Open
Aamir Jawaid (heyitsaamir) wants to merge 1 commit into
Open
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot started reviewing on behalf of
Aamir Jawaid (heyitsaamir)
August 18, 2026 16:11
View session
Contributor
There was a problem hiding this comment.
Pull request overview
Updates dependency versions and npm overrides to clear npm audit findings without accepting npm audit --force major-downgrade suggestions, primarily by moving the BotBuilder line forward and constraining vulnerable transitive paths (uuid, esbuild) via overrides.
Changes:
- Bump BotBuilder peer dependency from
4.23.1to4.23.3in the botbuilder package and example. - Add/extend root
overridesforuuidandtsup -> esbuild, and refinerestifyoverrides. - Regenerate
package-lock.json, updating a large set of transitive dependencies accordingly.
Show a summary per file
| File | Description |
|---|---|
| packages/botbuilder/package.json | Bumps botbuilder peer dependency to 4.23.3. |
| examples/botbuilder/package.json | Bumps example’s botbuilder dependency to 4.23.3. |
| package.json | Adds uuid and tsup -> esbuild overrides; updates restify override set. |
| package-lock.json | Reflects updated BotBuilder line and transitive dependency graph changes. |
Review details
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
- Files reviewed: 3/4 changed files
- Comments generated: 1
- Review effort level: Lite
Comment on lines
+65
to
69
| "tsup": { | ||
| "esbuild": "0.28.2" | ||
| }, | ||
| "uuid": "11.1.1", | ||
| "rollup": "4.62.3" |
| "@microsoft/teams.botbuilder": "*", | ||
| "@microsoft/teams.cards": "*", | ||
| "botbuilder": "4.23.1" | ||
| "botbuilder": "4.23.3" |
Collaborator
There was a problem hiding this comment.
Didn't we want to intentionally pin to 4.23.1? Or am I mis-remembering something?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This clears the workspace npm audit report while keeping the repo on current dependency lines instead of taking
npm audit --forcedowngrades. The security fix patches the BotBuilder line and constrains vulnerable transitiveuuid/esbuildpaths that upstream packages have not yet released with audit-safe ranges.Decisions
uuidadvisories. Keeping current packages and overriding only the vulnerable transitive packages avoids regressing supported package and example versions.npm outdatedstill reports non-security upgrades, including several majors; this PR limits movement to the install/audit fix path so reviewers can assess security risk separately from larger dependency migrations.Validation
npm audit --audit-level=lownpm run check:lockfile-registrynpx turbo build --filter=@microsoft/teams.botbuilder --filter=@examples/botbuildernpx turbo test --filter=@microsoft/teams.botbuilder