Repository navigation
fix: cancel observed focus delivery before it runs - #614
Closed
Amber (YuanboXue-Amber) wants to merge 2 commits into
Closed
Amber (YuanboXue-Amber) wants to merge 2 commits into
Amber (YuanboXue-Amber) wants to merge 2 commits into
Conversation
Retain the cancellable focus operation rather than only its element wait. Stop ready-target delivery on cancellation, supersession, and disposal, while preserving already-completed focus. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
📊 Bundle size reportUnchanged fixtures
|
Make focus cancellation idempotent and reject a pending element wait only while it still owns its registry entry. Add browser regressions for repeated cancellation of focus requests and element waits with the same name. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Fix a race where
requestFocus()could still move focus after cancellation, replacement by a newer request, or API disposal when the target was already found.No public API or dependency changes.
Validation