Repository navigation
Fix Ask AI agent creation and add debug-gated diagnostics - #1760
Merged
Paul Lizer (paullizer) merged 4 commits intoOct 13, 2026
Merged
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Replace the invalidated workflow reader source-only review with real SDK regressions and align the M365 route harness with the new diagnostic logger adapter. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Resolve the config.py-only conflict at version 0.261.330. The merged branch passes all 85 targeted regressions and has zero Cosmos inventory review gaps; record the completed 704-test contract run. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Paul Lizer (paullizer)
merged commit Oct 13, 2026
8f52ea8
into
paullizer-react-v2-ui
12 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
displayNameinstead of/displayNameand supplied blank connection details. Clarify the creation prompt's exact paths and distinguish them from parent-agentsetpaths; omit unknown connection details or ask for clarification instead of producing invalid placeholders.0.261.329. No deployment, restart, SQL connection, or stored Azure setting change was made.Linked issue
N/A. The user chose to continue without creating an issue.
Release Notes & Latest Features
Is this visible to end users?
Is this admin-facing (Admin Settings, governance, deployment, config)?
Should this become a Latest Feature card?
Screenshot needed for the card?
No new admin setting or UI control is introduced. Release notes remain unchanged because approval to update them was unavailable.
Version bump
application/single_app/config.pyVERSIONthird segment bumped, or not needed because this is docs-onlydeployers/version.txtbumped, or not needed becausedeployers/was not changedApplication version:
0.261.328->0.261.329. No deployer files changed.Testing / validation
Backend: 407 passed, 1 known baseline check deselected. Run in a session-isolated Python environment; production dependency manifests are unchanged.
Real-bundle browser coverage: 11 passed.
PLAYWRIGHT_SERVICE_URLwas empty andPYTHONPATHincludedui_tests\fixtures.npm --prefix .\application\v2_ui run build: passed, with the existing large-chunk warning. Generated assets are not included in this PR.python .\functional_tests\test_docs_app_surface_coverage.py: 7/7 checks passed, committed inventory current.python .\functional_tests\test_docs_site_quality.py: 6/6 checks passed.git -c core.whitespace=blank-at-eol,blank-at-eof,space-before-tab,cr-at-eol --no-pager diff --check: passed.Manual live-model reproduction: read-only Azure configuration identified the configured model; a local production-bundle fixture generated the real 12-field new-agent request with synthetic workspace choices. Both pre-fix runs returned 502. Six post-fix runs succeeded: four unfinished SQL drafts and two useful clarifications. The final two explicitly checked for no invented connection details, credential fields, or read-write SQL setting. No raw model responses or credentials were retained. The original historical response remains unavailable; this is fresh reproduction evidence, not a reconstruction of that response.
Known pre-existing failures: the deselected bootstrap AST assertion expects the old unwrapped gate expression rather than the existing
measure()wrapper. Earlier unfiltered coverage reported this failure.python -m pytest .\functional_tests\test_logging_tag_standardization.py .\functional_tests\test_log_event_call_contract.py -q --tb=shortreported 1 failed, 1 passed: legacy mixed-case tags fail normalization, while the logging call contract passes. Those unrelated tags are unchanged; new diagnostic tags use the normalized format.Documentation
Updated the agent/action and workflow Ask AI feature references and logging-tag inventory. Added
docs/explanation/fixes/ASK_AI_OPERATION_DIAGNOSTICS_FIX.mdwith the reproduced contract failure, privacy boundaries, validation evidence, and bounded single-line KQL examples. Release-note approval remains outstanding.Security checklist
@swagger_route(security=get_auth_security())sanitize_settings_for_user()No routes, settings-to-browser flows, or browser assets were added. Diagnostic properties use closed categorical allowlists and bounded measurements; prompts, drafts, replies, credentials, raw identity IDs, arbitrary field names, and provider exception text are excluded. Debug-off absence is covered in both logging sinks.