Skip to content

Restyle V2 Workflows in the Admin Settings design language - #1677

Merged
Paul Lizer (paullizer) merged 2 commits into
paullizer-react-v2-uifrom
paullizer-workflows-ui-redesign
Oct 7, 2026
Merged

Paul Lizer (paullizer) merged 2 commits into
paullizer-react-v2-uifrom
paullizer-workflows-ui-redesign

Conversation

@paullizer

Copy link
Copy Markdown
Contributor

Summary

Workflows was the largest V2 authoring surface still on the older layout: a long list of cards that each carried every action and an inline run history, and a modal editor with labels stacked over controls. This moves it onto the V2 Admin Settings design language, so it reads as the same system as Admin.

  • Workbench list (Model Catalog style). One-line rows lead with how each workflow stands (Running, Awaiting approval, Completed, Failed, ...) and its trigger, beside a detail pane with Overview, Runs and Flow tabs. Search plus Status and Trigger filters, including Needs attention. ?workflow_id= now selects a workflow, and &run_id= opens its Runs tab with that run expanded (chat run cards, notices and provenance links keep working unchanged).
  • Routed editor page. Edit and Create open /workspace/workflows/<id|new> (and /groups/<group>/workflows/<id|new>) in Admin's wide frame: header-band cards with Admin status chips, label-beside-control fields, paired switches, dependents nested under the control that leads them, and an On this page index. The chat proposal card still uses the same editor as a dialog. The separate Flow dialog is retired in favor of the Flow tab.
  • Status reads the server's record shape. When a run ends the server sets status back to idle and records the outcome in last_run_status, so the chips, the Overview's Last run, and Needs attention read that. The old list only echoed the raw status.

Review notes:

  • Shared primitives: SectionCard (Admin's card for non-Admin surfaces) and WorkflowField. Card status and meta logic is pure and tested in workflowEditorSections.ts; workbench labels, filters and facts in workflowWorkbench.ts.
  • Leave guard: the personal page uses useBlocker with the workspace leave prompt. In a group, the group page owns the guard (one blocker per route), so a workflow draft freezes the group switcher the way Settings does.
  • Converting a new draft to structured control flow left the Tasks card's contents unrendered in Chromium until a forced relayout. The card now remounts on conversion, and focus moves to it.
  • 27 existing UI suites now reach workflows through shared helpers in ui_tests/fixtures/workflow_workbench.py. Selectors moved from the dialog to the page region and from row buttons to the selected detail, with assertions kept at the same strength.

Workflows workbench at 1920px

Workflow editor page at 1920px

Workflow editor page at 390px

Linked issue

N/A - no linked issue.

Release Notes & Latest Features

  • New Feature
  • Bug Fix
  • UI Enhancement
  • Breaking Change
  • Internal only

Is this visible to end users?

  • Yes
  • No

Is this admin-facing (Admin Settings, governance, deployment, config)?

  • Yes
  • No

Should this become a Latest Feature card?

  • Yes
  • No
  • Already added

Screenshot needed for the card?

  • Yes
  • No
  • Attached

Left to the maintainer; the screenshots above can be reused for a card.

Version bump

  • application/single_app/config.py VERSION third segment bumped, or not needed because this is docs-only (0.261.271, after merging the target branch at 0.261.270)
  • deployers/version.txt bumped, or not needed because deployers/ was not changed

Testing / validation

  • npx tsc -b --noEmit and npm run build in application/v2_ui: passed
  • python -m pytest <38 affected UI suites> -q -p no:cacheprovider (every workflow suite, group workspace shell/journeys/classic handoffs, document provenance, group and public documents, the orchestration workflow suites, and the new ui_tests/test_v2_workflows_workbench_and_editor_layout.py), rerun after merging the target branch: 1,073 passed, 0 failed
  • python functional_tests/test_v2_workflows_admin_design_language.py (bundles and runs 18 TypeScript logic checks): 8/8 passed
  • python functional_tests/test_v2_admin_settings_layout.py 5/5, test_v2_admin_section_shell.py 5/5, test_v2_workflow_ask_ai.py 7/7, test_v2_workflow_change_tracking.py 4/4: passed
  • python -m pytest functional_tests/test_v2_orchestration_workflow_run_links_xss_guardrail.py functional_tests/test_v2_workflow_run_tracking_xss_guardrail.py functional_tests/test_xss_guardrails_checker.py: 23 passed
  • python scripts/check_xss_sinks.py --base-sha <parent> --head-sha <head> <26 changed application files>: passed
  • python functional_tests/test_docs_site_quality.py 6/6 and test_docs_app_surface_coverage.py 7/7: passed
  • Other functional tests that pin changed files (conversation drawer and export, documents explorer, new chat scoping, public workspace labels, settings and workspace tags, workflow alert client and sound parity, assist field parity, group workflow File Sync client parity): passed
  • Not run successfully locally, pre-existing: functional_tests/test_workflow_priority_alerts.py needs Cosmos DB credentials and fails the same way on the base commit.
  • Running locally: some UI suites need PYTHONPATH to include ui_tests and ui_tests/fixtures when they are collected first, and the orchestration suites need ui_tests/artifacts/orchestration-plan-editor built.
  • Design review: an independent finish review of desktop and mobile screenshots returned "pass with nits"; three of its four notes are addressed here (status words in rows, the detail scrolled into view on narrow screens, visible side-panel labels in the page header). The fourth asked to reword the pre-existing "Native V2 authoring..." intro, which existing tests pin, so it is left as is.

Documentation

  • Release notes updated, or not needed (not yet; happy to add an entry under 0.261.271)
  • Feature documentation updated, or not needed (new docs/explanation/features/V2_WORKFLOWS_WORKBENCH_AND_EDITOR.md; updated docs/guides/create-a-workflow.md, docs/guides/trigger-a-workflow.md, and cross-references in V2_GROUP_WORKFLOWS.md and WORKFLOW_FLOW_INSPECTION.md)
  • Fix documentation updated, or not needed (the fixes are part of this feature and are covered in the feature doc)

Security checklist

  • New Flask routes include @swagger_route(security=get_auth_security()) (no new Flask routes; the editor page is served by the existing /v2/<path:subpath> SPA route)
  • Settings sent to non-admin frontends use sanitize_settings_for_user() (no settings payload changes)
  • Browser JavaScript is served from local SimpleChat static assets only; no CDN-hosted JS
  • No secrets, keys, connection strings, or local-only artifacts are included

The new workflowListHref and workflowEditorHref builders are listed as reviewed same-origin builders in scripts/check_xss_sinks.py, and the run-link guardrail test now pins their exact return forms.

Paul Lizer (paullizer) and others added 2 commits October 6, 2026 20:21
- The Workflows list is a Model Catalog-style workbench: one-line rows that
  lead with how each workflow stands, beside a detail pane with Overview,
  Runs and Flow tabs, plus search and Status/Trigger filters. Run links
  select a workflow and open its run. Status reads last_run_status once the
  server sets a finished workflow back to idle.
- The editor is a routed page (/workspace/workflows/<id|new> and the group
  equivalent) in Admin's wide frame: header-band cards with Admin status
  chips, label-beside-control fields, paired switches, nested dependents and
  an On this page index. The chat proposal card keeps the dialog.
- Shared SectionCard and WorkflowField primitives; card status logic in
  workflowEditorSections.ts and workbench logic in workflowWorkbench.ts.
- The separate Flow dialog is retired; the Flow tab shows the saved flow.
- Feature doc, guides, functional and UI tests updated. Version 0.261.266.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
…261.271

The target branch moved to 0.261.270, so the redesign's version, its
documentation and its test headers move from 0.261.266 to 0.261.271.
Upstream's own 0.261.266 references are unchanged.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@paullizer
Paul Lizer (paullizer) merged commit 914156c into paullizer-react-v2-ui Oct 7, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant