Skip to content

Fix dark theme selector styling and harden chat retry upload flows - #1530

Merged
Paul Lizer (paullizer) merged 5 commits into
microsoft:Developmentfrom
Xeelee33:fix-dark-theme-css
Sep 28, 2026
Merged

Paul Lizer (paullizer) merged 5 commits into
microsoft:Developmentfrom
Xeelee33:fix-dark-theme-css

Conversation

@chadpalmer

Copy link
Copy Markdown
Contributor

Summary

  • Fixed the public workspace selector dropdown in dark theme so it matches the group workspace selector background, border, hover, and active item styling.
  • Added the shared workspace toolbar row class to the public workspace selector row.
  • Hardened chat upload file-access error handling so browser upload failures no longer depend on realm-specific TypeError checks.
  • Replaced retry modal HTML-string rendering with DOM APIs for safer model option cloning and reasoning effort controls.
  • Preserved retry/edit model endpoint identity when replaying model responses.
  • Added fix documentation, release notes, functional coverage, and UI regression coverage.

Validation

Passed:

  • git diff --check
  • python -m py_compile for changed Python files
  • python -m compileall -q application/single_app
  • node --check application/single_app/static/js/chat/chat-input-actions.js
  • node --check application/single_app/static/js/chat/chat-retry.js
  • python scripts/check_swagger_routes.py application/single_app/route_backend_conversations.py application/single_app/route_backend_retention_policy.py
  • python scripts/check_xss_sinks.py --full-file ...
  • python scripts/check_broken_access_control.py --full-file ...
  • python functional_tests/route_tests/test_route_blueprint_policy_inventory.py
  • python functional_tests/route_tests/test_route_unauthenticated_policy_contract.py
  • python functional_tests/route_tests/test_route_policy_test_coverage.py
  • python functional_tests/test_chat_clipboard_paste_upload_support.py
  • python functional_tests/test_chat_retry_edit_model_endpoint_replay.py

UI tests:

  • python -m pytest ui_tests/test_chat_clipboard_paste_upload_workflow.py -q
    • Result: skipped because local authenticated UI environment is not configured.
  • python -m pytest ui_tests/test_workspace_active_hero_shortcuts.py -q
    • Result: skipped because SIMPLECHAT_UI_BASE_URL and SIMPLECHAT_UI_STORAGE_STATE are not configured.

Version And Docs

  • Updated app version to 0.261.046.
  • Added release notes under v0.261.046.
  • Added fix documentation:
    • docs/explanation/fixes/CHAT_RETRY_EDIT_MODEL_ENDPOINT_REPLAY_FIX.md
    • docs/explanation/fixes/CHAT_UPLOAD_FILE_ACCESS_ERROR_FIX.md

Security Notes

  • XSS sink guardrail passed after replacing retry modal innerHTML usage with DOM APIs.
  • Broken access control guardrail passed for changed route files.
  • Swagger route validation passed for changed route files.
  • No obvious secret-like changed diff lines were found.
  • No raw settings exposure was identified in the changed frontend/template surface.

Known Gaps

  • Browser UI tests that require a running authenticated SimpleChat instance were skipped locally because the required environment variables/storage state were not configured.

@chadpalmer

Copy link
Copy Markdown
Contributor Author

Paul Lizer (@paullizer) Bionic711 This PR fixes a chat edit/retry glitch and the dark them css for a public group menu.

@paullizer

Copy link
Copy Markdown
Contributor

Copilot resolve the merge conflicts in this pull request

@paullizer

Copy link
Copy Markdown
Contributor

Chad Palmer (@chadpalmer) , would you resolve the conflict? then i will merge. Great submission! Thank you

@chadpalmer

Copy link
Copy Markdown
Contributor Author

Chad Palmer (Chad Palmer (@chadpalmer)) , would you resolve the conflict? then i will merge. Great submission! Thank you

Paul Lizer (@paullizer) I merged the release notes together and fixed the conflict. Please let me know if you need anything else. Thanks!

@paullizer
Paul Lizer (paullizer) merged commit e0e92af into microsoft:Development Sep 28, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants