Skip to content

fix(security): avoid missing buffer bounds check in uuid#2752

Merged
tido64 merged 1 commit intotrunkfrom
tido/address-xmldom-alerts
Apr 24, 2026
Merged

fix(security): avoid missing buffer bounds check in uuid#2752
tido64 merged 1 commit intotrunkfrom
tido/address-xmldom-alerts

Conversation

@tido64
Copy link
Copy Markdown
Member

@tido64 tido64 commented Apr 23, 2026

Description

I don't think we actually need to use v5 so replacing uuid with node:crypto seems like an obvious improvement.

Also addresses the following vulnerabilities:

Platforms affected

  • Android
  • iOS
  • macOS
  • visionOS
  • Windows

Test plan

n/a

@tido64 tido64 requested a review from JasonVMo as a code owner April 23, 2026 09:09
@tido64 tido64 enabled auto-merge (squash) April 23, 2026 09:09
@tido64 tido64 force-pushed the tido/address-xmldom-alerts branch from d526905 to a4804b5 Compare April 24, 2026 13:46
@tido64 tido64 requested a review from acoates-ms as a code owner April 24, 2026 13:46
@tido64 tido64 disabled auto-merge April 24, 2026 13:46
@tido64 tido64 enabled auto-merge (squash) April 24, 2026 13:46
@github-actions github-actions Bot added the platform: Windows This affects Windows label Apr 24, 2026
@tido64 tido64 changed the title chore(security): address security alerts fix(security): avoid missing buffer bounds check in uuid Apr 24, 2026
@tido64 tido64 merged commit 0487b7a into trunk Apr 24, 2026
25 checks passed
@tido64 tido64 deleted the tido/address-xmldom-alerts branch April 24, 2026 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

platform: Windows This affects Windows

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants