Repository navigation
Revert nested overload materialization and dependent checker fixes - #11739
Conversation
Selectively roll back #11601, #11621, and checker-only #11732 while preserving primer-analysis tooling and independent subsequent fixes. Retain regression fixtures and document the restored conformance, constructor, and protocol-operation limitations in current-behavior expectations. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
|
🔒 Automated review in progress — Bill Schnurr (@bschnurr) is auto-reviewing this PR. |
This comment has been minimized.
This comment has been minimized.
Bill Schnurr (bschnurr)
left a comment
There was a problem hiding this comment.
Approved via Review Center.
Regenerate with v0.86.2, preserve current artifact action versions, and prevent standalone runtime bumps with a narrow Dependabot ignore and workflow consistency coverage. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This comment has been minimized.
This comment has been minimized.
Replay each expanded argument using its own overload constraints and retain definitive constructed union branches. Fix the reproduced Werkzeug Mapping-to-dict regression without restoring nested overload materialization, and retain precise positive and negative regression coverage. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
|
Diff from mypy_primer, showing the effect of this PR on open source code: ibis (https://github.com/ibis-project/ibis)
- .../projects/ibis/ibis/common/tests/test_patterns.py:895:18 - error: Argument of type "list[int | Some]" cannot be assigned to parameter "pat" of type "Pattern" in function "match"
+ .../projects/ibis/ibis/common/tests/test_patterns.py:895:18 - error: Argument of type "list[int | SomeOf]" cannot be assigned to parameter "pat" of type "Pattern" in function "match"
- "list[int | Some]" is not assignable to "Pattern" (reportArgumentType)
+ "list[int | SomeOf]" is not assignable to "Pattern" (reportArgumentType)
- .../projects/ibis/ibis/common/tests/test_patterns.py:896:18 - error: Argument of type "list[int | Some]" cannot be assigned to parameter "pat" of type "Pattern" in function "match"
+ .../projects/ibis/ibis/common/tests/test_patterns.py:896:18 - error: Argument of type "list[int | SomeOf]" cannot be assigned to parameter "pat" of type "Pattern" in function "match"
- "list[int | Some]" is not assignable to "Pattern" (reportArgumentType)
+ "list[int | SomeOf]" is not assignable to "Pattern" (reportArgumentType)
- .../projects/ibis/ibis/common/tests/test_patterns.py:897:18 - error: Argument of type "list[int | Some]" cannot be assigned to parameter "pat" of type "Pattern" in function "match"
+ .../projects/ibis/ibis/common/tests/test_patterns.py:897:18 - error: Argument of type "list[int | SomeOf]" cannot be assigned to parameter "pat" of type "Pattern" in function "match"
- "list[int | Some]" is not assignable to "Pattern" (reportArgumentType)
+ "list[int | SomeOf]" is not assignable to "Pattern" (reportArgumentType)
- .../projects/ibis/ibis/common/tests/test_patterns.py:898:18 - error: Argument of type "list[int | Some]" cannot be assigned to parameter "pat" of type "Pattern" in function "match"
+ .../projects/ibis/ibis/common/tests/test_patterns.py:898:18 - error: Argument of type "list[int | SomeOf]" cannot be assigned to parameter "pat" of type "Pattern" in function "match"
- "list[int | Some]" is not assignable to "Pattern" (reportArgumentType)
+ "list[int | SomeOf]" is not assignable to "Pattern" (reportArgumentType)
- .../projects/ibis/ibis/common/tests/test_patterns.py:900:18 - error: Argument of type "list[Some | int]" cannot be assigned to parameter "pat" of type "Pattern" in function "match"
+ .../projects/ibis/ibis/common/tests/test_patterns.py:900:18 - error: Argument of type "list[SomeOf | int]" cannot be assigned to parameter "pat" of type "Pattern" in function "match"
- "list[Some | int]" is not assignable to "Pattern" (reportArgumentType)
+ "list[SomeOf | int]" is not assignable to "Pattern" (reportArgumentType)
- .../projects/ibis/ibis/common/tests/test_patterns.py:901:18 - error: Argument of type "list[Some | int]" cannot be assigned to parameter "pat" of type "Pattern" in function "match"
+ .../projects/ibis/ibis/common/tests/test_patterns.py:901:18 - error: Argument of type "list[SomeOf | int]" cannot be assigned to parameter "pat" of type "Pattern" in function "match"
- "list[Some | int]" is not assignable to "Pattern" (reportArgumentType)
+ "list[SomeOf | int]" is not assignable to "Pattern" (reportArgumentType)
- .../projects/ibis/ibis/common/tests/test_patterns.py:903:18 - error: Argument of type "list[int | Some]" cannot be assigned to parameter "pat" of type "Pattern" in function "match"
+ .../projects/ibis/ibis/common/tests/test_patterns.py:903:18 - error: Argument of type "list[int | SomeOf]" cannot be assigned to parameter "pat" of type "Pattern" in function "match"
- "list[int | Some]" is not assignable to "Pattern" (reportArgumentType)
+ "list[int | SomeOf]" is not assignable to "Pattern" (reportArgumentType)
- .../projects/ibis/ibis/common/tests/test_patterns.py:904:18 - error: Argument of type "list[int | Some]" cannot be assigned to parameter "pat" of type "Pattern" in function "match"
+ .../projects/ibis/ibis/common/tests/test_patterns.py:904:18 - error: Argument of type "list[int | SomeOf]" cannot be assigned to parameter "pat" of type "Pattern" in function "match"
- "list[int | Some]" is not assignable to "Pattern" (reportArgumentType)
+ "list[int | SomeOf]" is not assignable to "Pattern" (reportArgumentType)
- .../projects/ibis/ibis/common/tests/test_patterns.py:906:18 - error: Argument of type "list[Some]" cannot be assigned to parameter "pat" of type "Pattern" in function "match"
+ .../projects/ibis/ibis/common/tests/test_patterns.py:906:18 - error: Argument of type "list[SomeOf]" cannot be assigned to parameter "pat" of type "Pattern" in function "match"
- "list[Some]" is not assignable to "Pattern" (reportArgumentType)
+ "list[SomeOf]" is not assignable to "Pattern" (reportArgumentType)
- .../projects/ibis/ibis/common/tests/test_patterns.py:907:18 - error: Argument of type "list[Some | int]" cannot be assigned to parameter "pat" of type "Pattern" in function "match"
+ .../projects/ibis/ibis/common/tests/test_patterns.py:907:18 - error: Argument of type "list[SomeOf | int]" cannot be assigned to parameter "pat" of type "Pattern" in function "match"
- "list[Some | int]" is not assignable to "Pattern" (reportArgumentType)
+ "list[SomeOf | int]" is not assignable to "Pattern" (reportArgumentType)
- .../projects/ibis/ibis/common/tests/test_patterns.py:911:18 - error: Argument of type "list[int | Some]" cannot be assigned to parameter "pat" of type "Pattern" in function "match"
+ .../projects/ibis/ibis/common/tests/test_patterns.py:911:18 - error: Argument of type "list[int | SomeOf]" cannot be assigned to parameter "pat" of type "Pattern" in function "match"
- "list[int | Some]" is not assignable to "Pattern" (reportArgumentType)
+ "list[int | SomeOf]" is not assignable to "Pattern" (reportArgumentType)
- .../projects/ibis/ibis/common/tests/test_patterns.py:912:18 - error: Argument of type "tuple[Literal[1], Literal[2], Literal[3], Some]" cannot be assigned to parameter "pat" of type "Pattern" in function "match"
+ .../projects/ibis/ibis/common/tests/test_patterns.py:912:18 - error: Argument of type "tuple[Literal[1], Literal[2], Literal[3], SomeOf]" cannot be assigned to parameter "pat" of type "Pattern" in function "match"
- "tuple[Literal[1], Literal[2], Literal[3], Some]" is not assignable to "Pattern" (reportArgumentType)
+ "tuple[Literal[1], Literal[2], Literal[3], SomeOf]" is not assignable to "Pattern" (reportArgumentType)
- .../projects/ibis/ibis/common/tests/test_patterns.py:917:18 - error: Argument of type "list[int | Some]" cannot be assigned to parameter "pat" of type "Pattern" in function "match"
+ .../projects/ibis/ibis/common/tests/test_patterns.py:917:18 - error: Argument of type "list[int | SomeOf]" cannot be assigned to parameter "pat" of type "Pattern" in function "match"
- "list[int | Some]" is not assignable to "Pattern" (reportArgumentType)
+ "list[int | SomeOf]" is not assignable to "Pattern" (reportArgumentType)
- .../projects/ibis/ibis/common/tests/test_patterns.py:922:25 - error: Operator "@" not supported for types "Variable" and "Some" (reportOperatorIssue)
+ .../projects/ibis/ibis/common/tests/test_patterns.py:922:25 - error: Operator "@" not supported for types "Variable" and "SomeOf" (reportOperatorIssue)
- .../projects/ibis/ibis/common/tests/test_patterns.py:944:18 - error: Argument of type "list[int | Some]" cannot be assigned to parameter "pat" of type "Pattern" in function "match"
+ .../projects/ibis/ibis/common/tests/test_patterns.py:944:18 - error: Argument of type "list[int | SomeOf]" cannot be assigned to parameter "pat" of type "Pattern" in function "match"
- "list[int | Some]" is not assignable to "Pattern" (reportArgumentType)
+ "list[int | SomeOf]" is not assignable to "Pattern" (reportArgumentType)
- .../projects/ibis/ibis/common/tests/test_patterns.py:945:18 - error: Argument of type "list[int | Some]" cannot be assigned to parameter "pat" of type "Pattern" in function "match"
+ .../projects/ibis/ibis/common/tests/test_patterns.py:945:18 - error: Argument of type "list[int | SomeOf]" cannot be assigned to parameter "pat" of type "Pattern" in function "match"
- "list[int | Some]" is not assignable to "Pattern" (reportArgumentType)
+ "list[int | SomeOf]" is not assignable to "Pattern" (reportArgumentType)
- .../projects/ibis/ibis/common/tests/test_patterns.py:946:18 - error: Argument of type "list[int | Some]" cannot be assigned to parameter "pat" of type "Pattern" in function "match"
+ .../projects/ibis/ibis/common/tests/test_patterns.py:946:18 - error: Argument of type "list[int | SomeOf]" cannot be assigned to parameter "pat" of type "Pattern" in function "match"
- "list[int | Some]" is not assignable to "Pattern" (reportArgumentType)
+ "list[int | SomeOf]" is not assignable to "Pattern" (reportArgumentType)
- .../projects/ibis/ibis/common/tests/test_patterns.py:947:18 - error: Argument of type "list[int | Some]" cannot be assigned to parameter "pat" of type "Pattern" in function "match"
+ .../projects/ibis/ibis/common/tests/test_patterns.py:947:18 - error: Argument of type "list[int | SomeOf]" cannot be assigned to parameter "pat" of type "Pattern" in function "match"
- "list[int | Some]" is not assignable to "Pattern" (reportArgumentType)
+ "list[int | SomeOf]" is not assignable to "Pattern" (reportArgumentType)
- .../projects/ibis/ibis/common/tests/test_patterns.py:948:18 - error: Argument of type "list[int | Some]" cannot be assigned to parameter "pat" of type "Pattern" in function "match"
+ .../projects/ibis/ibis/common/tests/test_patterns.py:948:18 - error: Argument of type "list[int | SomeOf]" cannot be assigned to parameter "pat" of type "Pattern" in function "match"
- "list[int | Some]" is not assignable to "Pattern" (reportArgumentType)
+ "list[int | SomeOf]" is not assignable to "Pattern" (reportArgumentType)
... (truncated 102 lines) ...
sympy (https://github.com/sympy/sympy)
- .../projects/sympy/sympy/parsing/latex/lark/latex_parser.py
- .../projects/sympy/sympy/parsing/latex/lark/latex_parser.py:139:26 - error: No overloads for "join" match the provided arguments (reportCallIssue)
- .../projects/sympy/sympy/parsing/latex/lark/latex_parser.py:139:36 - error: Argument of type "list[Unknown | str]" cannot be assigned to parameter "iterable" of type "Iterable[LiteralString]" in function "join" (reportArgumentType)
- .../projects/sympy/sympy/solvers/bivariate.py:135:15 - error: Operator "-" not supported for "None" (reportOptionalOperand)
- .../projects/sympy/sympy/solvers/bivariate.py:139:17 - error: Operator "-" not supported for type "Basic | Unknown" (reportOperatorIssue)
- .../projects/sympy/sympy/solvers/bivariate.py:144:23 - error: Operator "-" not supported for "None" (reportOptionalOperand)
- .../projects/sympy/sympy/solvers/deutils.py:234:14 - error: Operator "not in" not supported for types "str" and "Unknown | int"
- Operator "not in" not supported for types "str" and "int" (reportOperatorIssue)
- .../projects/sympy/sympy/solvers/diophantine/diophantine.py:423:38 - error: Argument of type "Unknown | Expr | Literal[0]" cannot be assigned to parameter "expr" of type "Expr" in function "make_args"
+ .../projects/sympy/sympy/solvers/diophantine/diophantine.py:423:38 - error: Argument of type "int | Expr" cannot be assigned to parameter "expr" of type "Expr" in function "make_args"
- Type "Unknown | Expr | Literal[0]" is not assignable to type "Expr"
+ Type "int | Expr" is not assignable to type "Expr"
- "Literal[0]" is not assignable to "Expr" (reportArgumentType)
+ "int" is not assignable to "Expr" (reportArgumentType)
+ .../projects/sympy/sympy/solvers/diophantine/diophantine.py:504:19 - error: Operator "**" not supported for types "Unknown | Basic" and "Literal[2]"
+ Operator "**" not supported for types "Basic" and "Literal[2]" (reportOperatorIssue)
+ .../projects/sympy/sympy/solvers/diophantine/diophantine.py:505:19 - error: Operator "*" not supported for types "Unknown | Basic" and "Unknown | Basic"
+ Operator "*" not supported for types "Basic" and "Basic" (reportOperatorIssue)
+ .../projects/sympy/sympy/solvers/diophantine/diophantine.py:506:19 - error: Operator "**" not supported for types "Unknown | Basic" and "Literal[2]"
+ Operator "**" not supported for types "Basic" and "Literal[2]" (reportOperatorIssue)
+ .../projects/sympy/sympy/solvers/diophantine/diophantine.py:569:42 - error: Operator "*" not supported for types "int" and "Unknown | Basic"
+ Operator "*" not supported for types "int" and "Basic" (reportOperatorIssue)
+ .../projects/sympy/sympy/solvers/diophantine/diophantine.py:569:50 - error: Operator "*" not supported for types "Expr" and "Unknown | Basic"
+ Operator "*" not supported for types "Expr" and "Basic" (reportOperatorIssue)
+ .../projects/sympy/sympy/solvers/diophantine/diophantine.py:725:42 - error: Operator "**" not supported for types "Unknown | Basic" and "Literal[2]"
+ Operator "**" not supported for types "Basic" and "Literal[2]" (reportOperatorIssue)
+ .../projects/sympy/sympy/solvers/diophantine/diophantine.py:735:19 - error: Operator "**" not supported for types "Unknown | Basic" and "Literal[2]"
+ Operator "**" not supported for types "Basic" and "Literal[2]" (reportOperatorIssue)
+ .../projects/sympy/sympy/solvers/diophantine/diophantine.py:736:19 - error: Operator "**" not supported for types "Unknown | Basic" and "Literal[2]"
+ Operator "**" not supported for types "Basic" and "Literal[2]" (reportOperatorIssue)
+ .../projects/sympy/sympy/solvers/diophantine/diophantine.py:737:19 - error: Operator "**" not supported for types "Unknown | Basic" and "Literal[2]"
+ Operator "**" not supported for types "Basic" and "Literal[2]" (reportOperatorIssue)
+ .../projects/sympy/sympy/solvers/diophantine/diophantine.py:814:47 - error: Operator "**" not supported for types "Unknown | Basic" and "Literal[2]"
+ Operator "**" not supported for types "Basic" and "Literal[2]" (reportOperatorIssue)
+ .../projects/sympy/sympy/solvers/diophantine/diophantine.py:841:26 - error: Operator "**" not supported for types "Unknown | Basic" and "Literal[2]"
+ Operator "**" not supported for types "Basic" and "Literal[2]" (reportOperatorIssue)
+ .../projects/sympy/sympy/solvers/diophantine/diophantine.py:842:22 - error: Operator "*" not supported for types "Unknown | Basic" and "Unknown | Basic"
+ Operator "*" not supported for types "Basic" and "Basic" (reportOperatorIssue)
+ .../projects/sympy/sympy/solvers/diophantine/diophantine.py:843:36 - error: Operator "*" not supported for types "int" and "Unknown | Basic"
+ Operator "*" not supported for types "int" and "Basic" (reportOperatorIssue)
+ .../projects/sympy/sympy/solvers/diophantine/diophantine.py:843:42 - error: Operator "*" not supported for types "Unknown | Basic" and "Unknown | Basic"
+ Operator "*" not supported for types "Basic" and "Basic" (reportOperatorIssue)
+ .../projects/sympy/sympy/solvers/diophantine/diophantine.py:843:51 - error: Operator "*" not supported for types "int" and "Unknown | Basic"
+ Operator "*" not supported for types "int" and "Basic" (reportOperatorIssue)
+ .../projects/sympy/sympy/solvers/diophantine/diophantine.py:843:57 - error: Operator "*" not supported for types "Unknown | Basic" and "Unknown | Basic"
+ Operator "*" not supported for types "Basic" and "Basic" (reportOperatorIssue)
+ .../projects/sympy/sympy/solvers/diophantine/diophantine.py:843:66 - error: Operator "*" not supported for types "Unknown | Basic" and "Unknown | Basic"
+ Operator "*" not supported for types "Basic" and "Basic" (reportOperatorIssue)
+ .../projects/sympy/sympy/solvers/diophantine/diophantine.py:845:53 - error: Operator "*" not supported for types "Unknown | Basic" and "Unknown | Basic"
+ Operator "*" not supported for types "Basic" and "Basic" (reportOperatorIssue)
+ .../projects/sympy/sympy/solvers/diophantine/diophantine.py:854:18 - error: Operator "**" not supported for types "Unknown | Basic" and "Literal[2]"
+ Operator "**" not supported for types "Basic" and "Literal[2]" (reportOperatorIssue)
+ .../projects/sympy/sympy/solvers/diophantine/diophantine.py:856:22 - error: Operator "**" not supported for types "Unknown | Basic" and "Literal[2]"
+ Operator "**" not supported for types "Basic" and "Literal[2]" (reportOperatorIssue)
+ .../projects/sympy/sympy/solvers/diophantine/diophantine.py:865:22 - error: Operator "*" not supported for types "Unknown | Basic" and "Unknown | Basic"
+ Operator "*" not supported for types "Basic" and "Basic" (reportOperatorIssue)
+ .../projects/sympy/sympy/solvers/diophantine/diophantine.py:865:36 - error: Operator "*" not supported for types "Unknown | Basic" and "Unknown | Basic"
+ Operator "*" not supported for types "Basic" and "Basic" (reportOperatorIssue)
+ .../projects/sympy/sympy/solvers/diophantine/diophantine.py:867:27 - error: Operator "**" not supported for types "Unknown | Basic" and "Literal[2]"
+ Operator "**" not supported for types "Basic" and "Literal[2]" (reportOperatorIssue)
+ .../projects/sympy/sympy/solvers/diophantine/diophantine.py:868:27 - error: Operator "*" not supported for types "Unknown | Basic" and "Unknown | Basic"
+ Operator "*" not supported for types "Basic" and "Basic" (reportOperatorIssue)
+ .../projects/sympy/sympy/solvers/diophantine/diophantine.py:869:27 - error: Operator "*" not supported for types "Unknown | Basic" and "Unknown | Basic"
+ Operator "*" not supported for types "Basic" and "Basic" (reportOperatorIssue)
+ .../projects/sympy/sympy/solvers/diophantine/diophantine.py:870:27 - error: Operator "**" not supported for types "Unknown | Basic" and "Literal[2]"
+ Operator "**" not supported for types "Basic" and "Literal[2]" (reportOperatorIssue)
+ .../projects/sympy/sympy/solvers/diophantine/diophantine.py:871:27 - error: Operator "*" not supported for types "Unknown | Basic" and "Unknown | Basic"
+ Operator "*" not supported for types "Basic" and "Basic" (reportOperatorIssue)
+ .../projects/sympy/sympy/solvers/diophantine/diophantine.py:872:27 - error: Operator "**" not supported for types "Unknown | Basic" and "Literal[2]"
+ Operator "**" not supported for types "Basic" and "Literal[2]" (reportOperatorIssue)
+ .../projects/sympy/sympy/solvers/diophantine/diophantine.py:876:24 - error: Operator "**" not supported for types "Unknown | Basic" and "Literal[2]"
+ Operator "**" not supported for types "Basic" and "Literal[2]" (reportOperatorIssue)
+ .../projects/sympy/sympy/solvers/diophantine/diophantine.py:877:24 - error: Operator "**" not supported for types "Unknown | Basic" and "Literal[2]"
+ Operator "**" not supported for types "Basic" and "Literal[2]" (reportOperatorIssue)
+ .../projects/sympy/sympy/solvers/diophantine/diophantine.py:878:24 - error: Operator "**" not supported for types "Unknown | Basic" and "Literal[2]"
+ Operator "**" not supported for types "Basic" and "Literal[2]" (reportOperatorIssue)
+ .../projects/sympy/sympy/solvers/diophantine/diophantine.py:879:24 - error: Operator "*" not supported for types "Unknown | Basic" and "Unknown | Basic"
+ Operator "*" not supported for types "Basic" and "Basic" (reportOperatorIssue)
+ .../projects/sympy/sympy/solvers/diophantine/diophantine.py:880:24 - error: Operator "*" not supported for types "Unknown | Basic" and "Unknown | Basic"
+ Operator "*" not supported for types "Basic" and "Basic" (reportOperatorIssue)
+ .../projects/sympy/sympy/solvers/diophantine/diophantine.py:881:24 - error: Operator "*" not supported for types "Unknown | Basic" and "Unknown | Basic"
+ Operator "*" not supported for types "Basic" and "Basic" (reportOperatorIssue)
... (truncated 994 lines) ...
prefect (https://github.com/PrefectHQ/prefect)
+ .../projects/prefect/src/integrations/prefect-azure/tests/test_credentials.py:39:19 - error: Cannot access attribute "container_name" for class "None"
+ Attribute "container_name" is unknown (reportAttributeAccessIssue)
+ .../projects/prefect/src/integrations/prefect-azure/tests/test_credentials.py:52:19 - error: Cannot access attribute "container_name" for class "None"
+ Attribute "container_name" is unknown (reportAttributeAccessIssue)
+ .../projects/prefect/src/integrations/prefect-azure/tests/test_credentials.py:53:19 - error: Cannot access attribute "blob_name" for class "None"
+ Attribute "blob_name" is unknown (reportAttributeAccessIssue)
+ .../projects/prefect/src/integrations/prefect-dbt/tests/core/test_orchestrator_cache.py:1460:16 - error: Object of type "None" is not subscriptable (reportOptionalSubscript)
+ .../projects/prefect/src/integrations/prefect-dbt/tests/core/test_orchestrator_cache.py:1462:16 - error: Object of type "None" is not subscriptable (reportOptionalSubscript)
+ .../projects/prefect/src/integrations/prefect-dbt/tests/core/test_orchestrator_integration.py:479:28 - error: Cannot access attribute "keys" for class "None"
+ Attribute "keys" is unknown (reportAttributeAccessIssue)
+ .../projects/prefect/src/integrations/prefect-dbt/tests/core/test_orchestrator_integration.py:480:40 - error: Cannot access attribute "items" for class "None"
+ Attribute "items" is unknown (reportAttributeAccessIssue)
+ .../projects/prefect/src/integrations/prefect-dbt/tests/core/test_orchestrator_integration.py:501:13 - error: Object of type "None" is not subscriptable (reportOptionalSubscript)
+ .../projects/prefect/src/integrations/prefect-dbt/tests/core/test_orchestrator_integration.py:502:13 - error: Object of type "None" is not subscriptable (reportOptionalSubscript)
+ .../projects/prefect/src/integrations/prefect-dbt/tests/core/test_orchestrator_integration.py:505:13 - error: Object of type "None" is not subscriptable (reportOptionalSubscript)
+ .../projects/prefect/src/integrations/prefect-dbt/tests/core/test_orchestrator_integration.py:506:13 - error: Object of type "None" is not subscriptable (reportOptionalSubscript)
+ .../projects/prefect/src/integrations/prefect-dbt/tests/core/test_orchestrator_integration.py:508:24 - error: Object of type "None" is not subscriptable (reportOptionalSubscript)
+ .../projects/prefect/src/integrations/prefect-dbt/tests/core/test_orchestrator_integration.py:528:28 - error: Cannot access attribute "keys" for class "None"
+ Attribute "keys" is unknown (reportAttributeAccessIssue)
+ .../projects/prefect/src/integrations/prefect-dbt/tests/core/test_orchestrator_integration.py:529:31 - error: Cannot access attribute "values" for class "None"
+ Attribute "values" is unknown (reportAttributeAccessIssue)
+ .../projects/prefect/src/integrations/prefect-dbt/tests/core/test_orchestrator_integration.py:562:16 - error: Object of type "None" is not subscriptable (reportOptionalSubscript)
+ .../projects/prefect/src/integrations/prefect-dbt/tests/core/test_orchestrator_integration.py:563:16 - error: Object of type "None" is not subscriptable (reportOptionalSubscript)
+ .../projects/prefect/src/integrations/prefect-dbt/tests/core/test_orchestrator_integration.py:565:16 - error: Object of type "None" is not subscriptable (reportOptionalSubscript)
+ .../projects/prefect/src/integrations/prefect-dbt/tests/core/test_orchestrator_integration.py:566:16 - error: Object of type "None" is not subscriptable (reportOptionalSubscript)
+ .../projects/prefect/src/integrations/prefect-dbt/tests/core/test_orchestrator_integration.py:567:16 - error: Object of type "None" is not subscriptable (reportOptionalSubscript)
+ .../projects/prefect/src/integrations/prefect-dbt/tests/core/test_orchestrator_integration.py:584:40 - error: Cannot access attribute "items" for class "None"
+ Attribute "items" is unknown (reportAttributeAccessIssue)
+ .../projects/prefect/src/integrations/prefect-dbt/tests/core/test_orchestrator_integration.py:607:16 - error: Operator "not in" not supported for types "Literal['model.test_project.int_orders_enriched']" and "None" (reportOperatorIssue)
+ .../projects/prefect/src/integrations/prefect-dbt/tests/core/test_orchestrator_integration.py:626:40 - error: Cannot access attribute "items" for class "None"
+ Attribute "items" is unknown (reportAttributeAccessIssue)
+ .../projects/prefect/src/integrations/prefect-dbt/tests/core/test_orchestrator_integration.py:663:28 - error: Cannot access attribute "keys" for class "None"
+ Attribute "keys" is unknown (reportAttributeAccessIssue)
+ .../projects/prefect/src/integrations/prefect-dbt/tests/core/test_orchestrator_integration.py:664:40 - error: Cannot access attribute "items" for class "None"
+ Attribute "items" is unknown (reportAttributeAccessIssue)
+ .../projects/prefect/src/integrations/prefect-dbt/tests/core/test_orchestrator_integration.py:724:57 - error: Cannot access attribute "values" for class "None"
+ Attribute "values" is unknown (reportAttributeAccessIssue)
+ .../projects/prefect/src/integrations/prefect-dbt/tests/core/test_orchestrator_integration.py:733:56 - error: Cannot access attribute "values" for class "None"
+ Attribute "values" is unknown (reportAttributeAccessIssue)
+ .../projects/prefect/src/integrations/prefect-dbt/tests/core/test_orchestrator_integration.py:764:57 - error: Cannot access attribute "values" for class "None"
+ Attribute "values" is unknown (reportAttributeAccessIssue)
+ .../projects/prefect/src/integrations/prefect-dbt/tests/core/test_orchestrator_integration.py:783:69 - error: Cannot access attribute "values" for class "None"
+ Attribute "values" is unknown (reportAttributeAccessIssue)
+ .../projects/prefect/src/integrations/prefect-dbt/tests/core/test_orchestrator_integration.py:806:57 - error: Cannot access attribute "values" for class "None"
+ Attribute "values" is unknown (reportAttributeAccessIssue)
+ .../projects/prefect/src/integrations/prefect-dbt/tests/core/test_orchestrator_integration.py:813:57 - error: Cannot access attribute "values" for class "None"
+ Attribute "values" is unknown (reportAttributeAccessIssue)
+ .../projects/prefect/src/integrations/prefect-dbt/tests/core/test_orchestrator_integration.py:834:57 - error: Cannot access attribute "values" for class "None"
+ Attribute "values" is unknown (reportAttributeAccessIssue)
+ .../projects/prefect/src/integrations/prefect-dbt/tests/core/test_orchestrator_integration.py:847:56 - error: Cannot access attribute "values" for class "None"
+ Attribute "values" is unknown (reportAttributeAccessIssue)
+ .../projects/prefect/src/integrations/prefect-dbt/tests/core/test_orchestrator_integration.py:867:57 - error: Cannot access attribute "values" for class "None"
+ Attribute "values" is unknown (reportAttributeAccessIssue)
+ .../projects/prefect/src/integrations/prefect-dbt/tests/core/test_orchestrator_integration.py:874:57 - error: Cannot access attribute "values" for class "None"
+ Attribute "values" is unknown (reportAttributeAccessIssue)
+ .../projects/prefect/src/integrations/prefect-dbt/tests/core/test_orchestrator_integration.py:894:57 - error: Cannot access attribute "values" for class "None"
+ Attribute "values" is unknown (reportAttributeAccessIssue)
+ .../projects/prefect/src/integrations/prefect-dbt/tests/core/test_orchestrator_integration.py:903:57 - error: Cannot access attribute "values" for class "None"
+ Attribute "values" is unknown (reportAttributeAccessIssue)
+ .../projects/prefect/src/integrations/prefect-dbt/tests/core/test_orchestrator_integration.py:923:57 - error: Cannot access attribute "values" for class "None"
+ Attribute "values" is unknown (reportAttributeAccessIssue)
+ .../projects/prefect/src/integrations/prefect-dbt/tests/core/test_orchestrator_integration.py:927:57 - error: Cannot access attribute "values" for class "None"
+ Attribute "values" is unknown (reportAttributeAccessIssue)
+ .../projects/prefect/src/integrations/prefect-dbt/tests/core/test_orchestrator_integration.py:935:56 - error: Cannot access attribute "values" for class "None"
+ Attribute "values" is unknown (reportAttributeAccessIssue)
+ .../projects/prefect/src/integrations/prefect-dbt/tests/core/test_orchestrator_integration.py:957:57 - error: Cannot access attribute "values" for class "None"
+ Attribute "values" is unknown (reportAttributeAccessIssue)
+ .../projects/prefect/src/integrations/prefect-dbt/tests/core/test_orchestrator_integration.py:974:69 - error: Cannot access attribute "values" for class "None"
+ Attribute "values" is unknown (reportAttributeAccessIssue)
+ .../projects/prefect/src/integrations/prefect-dbt/tests/core/test_orchestrator_integration.py:1062:33 - error: "None" is not iterable
+ "__iter__" method not defined (reportGeneralTypeIssues)
+ .../projects/prefect/src/integrations/prefect-dbt/tests/core/test_orchestrator_integration.py:1063:32 - error: "None" is not iterable
+ "__iter__" method not defined (reportGeneralTypeIssues)
+ .../projects/prefect/src/integrations/prefect-dbt/tests/core/test_orchestrator_integration.py:1068:20 - error: Object of type "None" is not subscriptable (reportOptionalSubscript)
+ .../projects/prefect/src/integrations/prefect-dbt/tests/core/test_orchestrator_integration.py:1069:39 - error: Object of type "None" is not subscriptable (reportOptionalSubscript)
+ .../projects/prefect/src/integrations/prefect-dbt/tests/core/test_orchestrator_integration.py:1088:33 - error: "None" is not iterable
+ "__iter__" method not defined (reportGeneralTypeIssues)
+ .../projects/prefect/src/integrations/prefect-dbt/tests/core/test_orchestrator_integration.py:1089:32 - error: "None" is not iterable
... (truncated 181 lines) ...
... (truncated 243 lines) ...``` |
|
Result: Verification detailsVerification: The relevant tests could not be fully run in the isolated environment; this review is not fully verified. Summary: Targeted analyzer tests covering the overload rollback and constructor union handling passed: 6/6. The updated `mapSignatures` test and TypeScript compilation also passed. The new compiler/runtime workflow test was selected with an overly strict pattern and Jest skipped it; the command was not rerun due to the execution budget. Verification is therefore strong for checker behavior but incomplete for workflow consistency. Test runs: 5 passed, 1 skipped
⏩
|
Summary
Selectively restore pre-materialization overload behavior after the pandas regressions introduced by nested overload materialization and unsuccessful incremental design experiments. This is a rollback to establish a baseline before a separate redesign, not a conformance fix or a replacement algorithm.
Based on
microsoft/pyright:mainate4967c79c05c7823f226893208d0324f0c1accd8. The rollback was prepared and measured in isolation; its current-behavior test changes were reviewed before publication.Reverted and retained scope
mapSignaturestest to the restored callback contract; this does not claim equivalent expansion coverage.No downstream expectations are changed. Earlier experimental algorithms and local evidence artifacts are not included.
Measured pandas compatibility
Using pandas-stubs commit
711cf2f7eedaee369812d293a9cc83a08432096b, Python 3.12.13, and the same read-only source and installed-wheel snapshots:All runs had zero warnings. Each shape removes the same 47 diagnostics with no additions, compared by normalized file, range, rule, and message: 23 assertion mismatches and 24 unnecessary-ignore diagnostics. These are diagnostic differences, not a claim of 47 distinct language bugs.
These corpus runs were measured before the test-only increment. All 7,716 tracked files outside the six authorized test/sample files were subsequently SHA256-compared and unchanged, including analyzer, stubs, dependencies, and build inputs. The corpus was therefore not rerun for test-only edits. The results match the retained pin's diagnostic sets for these exact snapshots; they do not establish universal pandas compatibility or complete equivalence to 1.1.411.
Intentional restored limitations
list[Any]overload conformance example again selects the firstlist[int]result and rejects the required assignment tolist[str]and supported string mutation. The requirement is assignability to both retained result types and support for their valid operations, not merely a particularAnyassertion.The affected overload samples explicitly document these as current rollback limitations, not required semantics. All 176 existing type-expectation sites remain, with 67 expectations adjusted to the deliberately reverted behavior. Concrete, unambiguous, equivalent-return, genuinely covering-overload, constructor-union, protocol, and negative-member controls are retained. Exact diagnostic rules/messages remain asserted where applicable. The original conformance sample retains both assignments and both mutation checks.
A test-only restructuring separates restored
Nevercalls so they cannot hide independent Unknown/fallback checks as unreachable. Five previously hidden Unknown expectations are now analyzed. Tests are not skipped or silenced to conceal the limitations. A green suite documents this chosen behavior; it does not resolve these semantic losses.Validation and reproducibility
The final normal suite was actually run once on the final reviewed tree, including its normal test-server build prerequisite and only its normal benchmark exclusion:
2,830/2,830 tests and 78/78 suites passed, with zero pending/todo tests, zero runtime-error suites, and no interruption. Focused affected overload tests, targeted Prettier/ESLint, and TypeScript checking also passed. No additional suite loop was run for publication; the committed diff was confirmed identical to the tested and reviewed snapshot.
All 53 mainline merges after #11601 through the fixed starting SHA were audited, and independent later-fix sample registrations were correlated with the full machine-readable results. No unrelated failing tests were identified. This includes retained protocol54, class/dataclass defaults, TypeForm, Sentinel, duplicate declarations, function metadata, callable keyword, TypeIs, enum narrowing, partial, TypedDict, iterable, cache-clearing, synchronization, and primer controls. This is explicit regression coverage, not proof of every possible behavior.
Existing harness warnings remain unresolved: both the earlier unadjusted rollback run and the final run emitted
MaxListenersExceededWarningand a worker-not-exiting-gracefully/forced-exit teardown warning. The final command exited zero, but the infrastructure was not warning-free.For the pandas measurements, build the CLI and use an absolute path to that build. With
$sourceSnapshot,$wheelSnapshot, and$pythonidentifying the frozen snapshots and their shared Python 3.12 interpreter, and$resultsan external evidence directory:The source run has no positional path; the wheel run analyzes
testsand resolves the installed stub wheel rather than local source stubs. Diagnostic exit code 1 is expected for comparison runs that report errors.