You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
fix(expect): support constructors in expect.arrayOf - #43126
4 flaky⚠️ [chromium-library] › library/webmcp.spec.ts:256 › should list and call tools in cross-origin and nested frames `@chromium-ubuntu-22.04-node20` ⚠️ [firefox-library] › library/browsercontext-cookies-third-party.spec.ts:257 › third party 'Partitioned;' cookies `@firefox-ubuntu-22.04-node20` ⚠️ [firefox-library] › library/browsercontext-cookies-third-party.spec.ts:470 › top level 'Partitioned;' cookie and same origin iframe `@firefox-ubuntu-22.04-node20` ⚠️ [webkit-page] › page/page-set-input-files.spec.ts:38 › should upload a folder `@webkit-ubuntu-22.04-node20`
🟢 Green — the failure is a confirmed pre-existing flake
Hi, I'm the Playwright bot and I took a first look at the CI failure here.
The only real failure is [firefox] › mcp/cli-devtools.spec.ts:140 › request* and response* commands support --filename on Windows. The same test has failed with the same assertion on several unrelated PRs, while this PR only changes expect.arrayOf constructor matching and its test coverage.
Details
The PR changes packages/playwright/src/matchers/expectLibrary.ts and tests/playwright-test/expect.spec.ts; it does not reach the MCP devtools CLI, Firefox request handling, or the failing test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
expect.arrayOf(String)/expect.arrayOf(MyClass)now match by type, as documented, by treating a constructor asexpect.any(constructor).Fixes #43117