Skip to content

[api review 1.65] Failures reporter, onlyFailures and --reporter-only-failures #43794

Closed

Description

PR #42766, Issue #42702

  • drop --reporter-only-failures
  • does onlyFailures option in the html/json/junit include flaky tests? clarify in the docs

Part of the 1.65 API review: #43790

Activity

  1. github-actions commented on Oct 30, 2026

    @github-actions
  2. github-actions commented on Oct 30, 2026

    @github-actions
    Contributor

    Hi, I'm the Playwright bot and I checked this API review item.

    Fix proposed. Removed --reporter-only-failures from both test and merge-reports, including its internal configuration override. The per-reporter onlyFailures option remains. The HTML, JSON, and JUnit documentation now explicitly says that flaky tests and their successful retries are included.

    Verification

    On Linux, using 1.65.0-next at base commit 1d5572d5ddfb7f3c8dfbbe19c8e97def0b2738db:

    • The updated command-line test failed before the change because the removed flag was still accepted. It passes with the change for both commands.
    • Existing report tests pass with onlyFailures configured separately for HTML, JSON, and JUnit, for direct runs and merged blob reports. They verify that flaky tests retain both the failed and successful attempts, while blob reports retain all tests.
    • npm run ttest -- reporter-only-failures reporter-json reporter-junit reporter-blob --workers=4: 129 passed, 3 skipped.
    • npm run build and npm run flint passed.

    These are test-runner and report-generation checks; the changed tests do not launch browsers.

    Draft PR: #43805

    Triaged on Linux by the Playwright bot - agent run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions