Repository navigation
fix(docker): narrow the Docker build context and keep the checkout credentials out of it - #2035
Closed
Yury Semikhatsky (yury-s) wants to merge 3 commits into
Closed
Yury Semikhatsky (yury-s) wants to merge 3 commits into
Yury Semikhatsky (yury-s) wants to merge 3 commits into
Conversation
…line and the build context Check out the repository without persisting the credentials in the git config, and exclude .git from the Docker build context.
Copy the root POM and the driver, driver-bundle and playwright modules into the build instead of the whole build context, and keep the target directories out of the build context.
The official Node.js Linux binaries link against libatomic since Node.js 25, and the driver runs before install-deps adds it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
persistCredentials: falsein the publish pipeline, and exclude.gitand thetargetdirectories from the Docker build context.COPYonly the root POM and the driver, driver-bundle and playwright modules into the image build instead of the whole build context.libatomic1, which the Node.js Linux binaries link against since Node.js 25; the driver runs beforeinstall-deps.