Skip to content

Require HTTPS in restricted HTTP builds - #363

Merged
Pino de Candia (pinodeca) merged 1 commit into
mainfrom
waldemort/issue-342-require-https
Aug 28, 2026
Merged

Require HTTPS in restricted HTTP builds#363
Pino de Candia (pinodeca) merged 1 commit into
mainfrom
waldemort/issue-342-require-https

Conversation

@waldemort-auto

Copy link
Copy Markdown
Contributor

Summary

Restricted HTTP allow-list builds currently permit plaintext http:// requests. That can expose authorization headers, credentials, and request bodies in transit.

This change:

  • requires HTTPS when http-allow-azure-domains or http-allow-test-domains is enabled;
  • preserves HTTP and HTTPS support for development-only http-allow-all builds;
  • applies the same scheme policy during DSL construction and execution, including raw HTTP and multipart nodes;
  • keeps existing SSRF checks authoritative by updating bare-IP test vectors to HTTPS;
  • documents the feature-dependent transport policy and records the fix for issue df.http() permits credentials over plaintext HTTP to allow-listed domains #342.

Validation

  • git diff --check
  • SQL regression coverage added for regular, multipart, raw-node, and allow-all paths
  • Feature-specific Rust unit tests added for restricted, allow-all, and HTTP-disabled builds

Cargo-based validation could not run in the repo-cache environment because cargo is unavailable (bash: line 1: cargo: command not found).

Prevent credentials and request bodies from being transmitted over plaintext HTTP when a restricted allow-list feature is enabled. Keep plaintext support for development-only http-allow-all builds and cover DSL and raw-node execution paths.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

@pinodeca Pino de Candia (pinodeca) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed with Opus 4.8, no issues found.

@pinodeca
Pino de Candia (pinodeca) merged commit acb9e51 into main Aug 28, 2026
6 of 7 checks passed
@pinodeca
Pino de Candia (pinodeca) deleted the waldemort/issue-342-require-https branch August 28, 2026 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

df.http() permits credentials over plaintext HTTP to allow-listed domains

2 participants