Require HTTPS in restricted HTTP builds - #363
Merged
Pino de Candia (pinodeca) merged 1 commit intoAug 28, 2026
Merged
Conversation
Prevent credentials and request bodies from being transmitted over plaintext HTTP when a restricted allow-list feature is enabled. Keep plaintext support for development-only http-allow-all builds and cover DSL and raw-node execution paths. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Pino de Candia (pinodeca)
approved these changes
Aug 28, 2026
Pino de Candia (pinodeca)
left a comment
Contributor
There was a problem hiding this comment.
Reviewed with Opus 4.8, no issues found.
Pino de Candia (pinodeca)
deleted the
waldemort/issue-342-require-https
branch
August 28, 2026 17:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Restricted HTTP allow-list builds currently permit plaintext
http://requests. That can expose authorization headers, credentials, and request bodies in transit.This change:
http-allow-azure-domainsorhttp-allow-test-domainsis enabled;http-allow-allbuilds;Validation
git diff --checkCargo-based validation could not run in the repo-cache environment because
cargois unavailable (bash: line 1: cargo: command not found).