Improve secrets handling - #361
Draft
Thom Chiovoloni (thomcc) wants to merge 4 commits into
Draft
Conversation
added 4 commits
August 25, 2026 16:27
Adds `pg_durable.log_workflow_sql` postmaster GUC. This controls whether or not the worker will write the fully substituted SQL text of a workflow node to the server log. Redacts URLs in logs and errors. Query parameter values, user info, and the fragment are elided. This means that an Azure SAS token, or `?api-key=` won't reach the PG server log, `df.nodes.error`, or durable execution history. Other parts of the URL are preserved. Error text from the HTTP client is scrubbed too, since it interpolates the URL. Adds documentation that's honest about df.vars and potential exposure to USER_GUIDE.md.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is still very WIP. Several parts of it (script changes) were made just to get things working in my env (I'll pull them into a separate PR later, or adjust my env so that they aren't needed), and it only handles redaction and stripping of logs. Still working on this.