Skip to content

openhcl_boot: remove VTL2 vmbus connection ID plumbing - #4690

Merged
Ben Hillis (benhillis) merged 4 commits into
microsoft:mainfrom
hargar19:user/hargar/conn-id-removal
Oct 20, 2026
Merged

Ben Hillis (benhillis) merged 4 commits into
microsoft:mainfrom
hargar19:user/hargar/conn-id-removal

Conversation

@hargar19

Copy link
Copy Markdown
Contributor

Update the OpenHCL kernel revision to use the upstream device connection ID support: kernel PR: microsoft/OHCL-Linux-Kernel#162

The kernel now selects the VTL2 vmbus message connection ID at runtime, so this change:

  • Stops passing hv_vmbus.message_connection_id on the kernel command line.
  • Removes parsing of microsoft,message-connection-id from the host device tree.
  • Stops forwarding the connection ID to the VTL2 device tree.
  • Removes the now-unused host parameter plumbing.

Signed-off-by: Hardik Garg <hargar@linux.microsoft.com>

The OpenHCL kernel now determines the VTL2 vmbus message connection ID
itself (microsoft/OHCL-Linux-Kernel#162), so the hv_vmbus.message_connection_id
command line hack is no longer needed.

Signed-off-by: Hardik Garg <hargar@linux.microsoft.com>
The OpenHCL kernel now picks the VTL2 vmbus message connection ID at
runtime (microsoft/OHCL-Linux-Kernel#162) and nothing else consumes
microsoft,message-connection-id, so stop parsing it from the host device
tree and stop forwarding it to the VTL2 device tree.

Signed-off-by: Hardik Garg <hargar@linux.microsoft.com>
Signed-off-by: Hardik Garg <hargar@linux.microsoft.com>
Copilot AI balanced review requested due to automatic review settings October 19, 2026 17:43
@github-actions github-actions Bot added the unsafe Related to unsafe code label Oct 19, 2026
@github-actions

Copy link
Copy Markdown

⚠️ Unsafe Code Detected

This PR modifies files containing unsafe Rust code. Extra scrutiny is required during review.

For more on why we check whole files, instead of just diffs, check out the Rustonomicon

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Nix still selects the older kernel, breaking VMBus initialization on hosts requiring the redirect connection ID.

1 open issue
What changed in this PR

Moves OpenHCL boot to kernel-managed VTL2 VMBus connection-ID selection.

Changes:

  • Updates the default kernel to 6.18.37.6.
  • Removes connection-ID command-line, device-tree, and host-parameter plumbing.
  • Adjusts parser tests for the smaller device tree.
File Description
openhcl/​openhcl_boot/​src/​main.rs Removes the kernel command-line override.
openhcl/​openhcl_boot/​src/​host_params/​mod.rs Removes connection-ID initialization.
openhcl/​openhcl_boot/​src/​host_params/​dt/​mod.rs Preserves node validation without copying IDs.
openhcl/​openhcl_boot/​src/​dt.rs Stops emitting connection-ID properties.
openhcl/​host_fdt_parser/​src/​lib.rs Removes ID parsing and updates tests.
flowey/​flowey_lib_hvlite/​src/​_jobs/​cfg_versions.rs Updates the default kernel version.

Review effort: Balanced

Keep the Nix kernel packages in sync with the Flowey release version and update the hashes for the x64, arm64, and CVM x64 artifacts.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: Hardik Garg <hargar@linux.microsoft.com>
Copilot AI balanced review requested due to automatic review settings October 19, 2026 17:54

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Boot-critical runtime negotiation needs human-confirmed validation across supported hosts, architectures, and isolation modes.

1 open issue

Review effort: Balanced

@hargar19
Hardik Garg (hargar19) marked this pull request as ready for review October 19, 2026 18:32
@hargar19
Hardik Garg (hargar19) requested a review from a team as a code owner October 19, 2026 18:32
@github-actions

Copy link
Copy Markdown

@benhillis
Ben Hillis (benhillis) merged commit 7f8513a into microsoft:main Oct 20, 2026
146 of 148 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

unsafe Related to unsafe code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants