Validate ORT format input argument counts - #32865
Open
danielsongmicrosoft wants to merge 1 commit into
Open
danielsongmicrosoft wants to merge 1 commit into
danielsongmicrosoft wants to merge 1 commit into
Conversation
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The variadic normalization test fails in minimal builds because normalization only occurs during full-build graph resolution.
Review effort: Balanced
Findings: 1
Open (1)
What changed in this PR
Validates ORT-format node input counts during model loading while preserving full-build variadic normalization.
Changes:
- Rejects negative, overflowing, and mismatched input counts.
- Adds malformed-model and variadic normalization tests.
| File | Description |
|---|---|
onnxruntime/core/graph/graph.cc |
Adds safe input-count validation and accumulation. |
onnxruntime/test/framework/ort_model_only_test.cc |
Adds input-count loading tests. |
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
danielsongmicrosoft
force-pushed
the
user/danielsongmicrosoft/onnxruntime-robustness-85842017fe01
branch
from
September 28, 2026 19:43
e137a69 to
d28e922
Compare
danielsongmicrosoft
marked this pull request as ready for review
September 28, 2026 19:54
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation