Reject recursive function graph attributes - #32864
Open
danielsongmicrosoft wants to merge 1 commit into
Open
danielsongmicrosoft wants to merge 1 commit into
danielsongmicrosoft wants to merge 1 commit into
Conversation
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The cycle tracking is scoped correctly, errors propagate to callers, and tests cover recursive and valid reuse paths.
Review effort: Balanced
Findings: None
What changed in this PR
Adds cycle detection to function specialization, preventing recursive GRAPH/GRAPHS attribute expansion from causing unbounded recursion.
Changes:
- Tracks active graph-attribute references and returns a diagnostic cycle chain.
- Propagates specialization failures through function inlining.
- Tests recursive, non-recursive, and sequential reuse scenarios.
| File | Description |
|---|---|
onnxruntime/core/graph/function_utils.cc |
Implements cycle detection and status propagation. |
onnxruntime/core/graph/function_utils.h |
Changes specialization APIs to return Status. |
onnxruntime/core/graph/graph.cc |
Propagates specialization errors during inlining. |
onnxruntime/test/framework/function_test.cc |
Adds focused graph-attribute recursion tests. |
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
danielsongmicrosoft
marked this pull request as ready for review
September 28, 2026 19:55
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation