Check CPU fallback assignments in nested subgraphs - #32862
Open
danielsongmicrosoft wants to merge 1 commit into
Open
danielsongmicrosoft wants to merge 1 commit into
danielsongmicrosoft wants to merge 1 commit into
Conversation
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The recursive validation is correct, scoped appropriately, and covered by focused regression tests.
Review effort: Balanced
Findings: None
What changed in this PR
Recursively enforces disabled CPU fallback across nested ONNX subgraphs.
Changes:
- Adds recursive CPU EP assignment detection.
- Uses it during session initialization.
- Adds nested control-flow regression tests.
| File | Description |
|---|---|
onnxruntime/core/session/inference_session.cc |
Applies recursive assignment validation. |
onnxruntime/core/session/inference_session_utils.h |
Declares the validation helper. |
onnxruntime/core/session/inference_session_utils.cc |
Implements recursive subgraph traversal. |
onnxruntime/test/framework/inference_session_test.cc |
Tests rejected and fully assigned nested graphs. |
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
danielsongmicrosoft
marked this pull request as ready for review
September 28, 2026 19:55
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation