Require canceling transpose paths for shared outputs - #32861
Closed
hendrickhan wants to merge 1 commit into
Closed
hendrickhan wants to merge 1 commit into
hendrickhan wants to merge 1 commit into
Conversation
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Consumer completeness and execution-provider boundaries can produce false cancellation-path results.
Review effort: Balanced
Findings: 1
Open (1)
What changed in this PR
Updates transpose-cost heuristics to require viable cancellation paths for shared outputs.
Changes:
- Adds downstream canceling-transpose path detection.
- Adds QDQ branching regression coverage.
| File | Description |
|---|---|
onnxruntime/core/optimizer/transpose_optimization/onnx_transpose_optimization.cc |
Refines shared-output transpose cost calculation. |
onnxruntime/test/optimizer/transpose_optimizer_test.cc |
Tests branched QDQ transpose behavior. |
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+2989
to
+2990
| for (auto& consumer : consumers->nodes) { | ||
| if (consumer->IsOp("Transpose")) { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context