[refac] Fix missed renames from 'appcontainer' to 'process_container' - #1226
Open
Jeff Whiteside (jsidewhite) wants to merge 1 commit into
Open
Jeff Whiteside (jsidewhite) wants to merge 1 commit into
Jeff Whiteside (jsidewhite) wants to merge 1 commit into
Conversation
Jeff Whiteside (jsidewhite)
requested review from
Branden Bonaby (bbonaby)
and
a balanced review from Copilot
September 21, 2026 23:52
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Copilot started reviewing on behalf of
Jeff Whiteside (jsidewhite)
September 21, 2026 23:53
View session
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The crate rename is consistently propagated across manifests, code, examples, tests, and documentation.
Review effort: Balanced
Findings: None
What changed in this PR
Renames the Windows ProcessContainer backend crate from appcontainer_common to process_container_common across the codebase.
Changes:
- Updates workspace manifests, feature forwarding, and lockfile entries.
- Updates Rust references, examples, tests, and documentation.
- Preserves existing backend behavior while correcting stale naming.
| File | Description |
|---|---|
| src/testing/wxc_e2e_tests/tests/e2e_processcontainer_characterization.rs | Updates test documentation references. |
| src/core/wxc/src/main.rs | Uses the renamed backend crate. |
| src/core/wxc/src/audit.rs | Updates capture-output access and comments. |
| src/core/wxc/Cargo.toml | Renames the dependency and feature forwarding. |
| src/core/wxc_common/src/test_env.rs | Updates test-helper documentation. |
| src/core/mxc-sdk/README.md | Updates dispatcher documentation. |
| src/core/mxc_engine/src/run.rs | Updates runner dispatch references. |
| src/core/mxc_engine/src/probe.rs | Updates probe and tier references. |
| src/core/mxc_engine/src/guarded_capture.rs | Updates guarded-capture imports and documentation. |
| src/core/mxc_engine/src/dispatch.rs | Updates streaming dispatcher references. |
| src/core/mxc_engine/Cargo.toml | Renames the dependency and forwarded features. |
| src/Cargo.toml | Renames the workspace dependency. |
| src/Cargo.lock | Records the renamed crate dependency. |
| src/backends/wslc/common/src/wslc_bindings.rs | Updates a related documentation reference. |
| src/backends/wslc/common/src/sandbox.rs | Updates a related documentation reference. |
| src/backends/process_container/common/src/probe.rs | Updates crate documentation. |
| src/backends/process_container/common/src/guarded_capture.rs | Updates guarded-capture documentation. |
| src/backends/process_container/common/src/appcontainer_runner.rs | Updates layering documentation. |
| src/backends/process_container/common/examples/lm_probe.rs | Updates example commands and crate paths. |
| src/backends/process_container/common/examples/lm_capture.rs | Updates example commands and imports. |
| src/backends/process_container/common/Cargo.toml | Renames the crate package. |
| docs/backend-support-probe-api-plan.md | Updates backend planning documentation. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Branden Bonaby (bbonaby)
approved these changes
Sep 21, 2026
Gudge (MGudgin)
approved these changes
Sep 22, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rename.
Microsoft Reviewers: Open in CodeFlow