Skip to content

WSLC scripts and tests now check for ARM targets on ARM systems - #1221

Open
Elliot (theelliotm) wants to merge 4 commits into
mainfrom
user/emichlin/wslc-script-support-arm
Open

Elliot (theelliotm) wants to merge 4 commits into
mainfrom
user/emichlin/wslc-script-support-arm

Conversation

@theelliotm

@theelliotm Elliot (theelliotm) commented Sep 21, 2026

Copy link
Copy Markdown
Contributor

📖 Description

Currently, WSLC scripts and tests hardcode the x86 target. ARM systems must manually pass WxcExecPath to circumvent error messages saying wxc-exec.exe not found.

This PR changes the scripts/tests so they check the processor architecture and use the appropriate target.

🔗 References

🔍 Validation

Ran all scripts manually on my ARM machine.

✅ Checklist

📋 Issue Type

  • Bug fix
  • Feature
  • Task
Microsoft Reviewers: Open in CodeFlow

@theelliotm
Elliot (theelliotm) requested a review from a team as a code owner September 21, 2026 19:12
Copilot AI balanced review requested due to automatic review settings September 21, 2026 19:12
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
There may be pipelines that require an authorized user to comment /azp run to run.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

Host detection remains incorrect when PowerShell or Command Prompt runs under x86/x64 emulation on ARM64.

Get a fresh assessment by requesting another Copilot review.

Review effort: Balanced
Findings: 8 Medium severity · 1 Low severity

Open (9)
What changed in this PR

Updates WSLc tooling to locate ARM64 build outputs on ARM64 hosts.

Changes:

  • Selects ARM64 or x64 Rust targets based on detected architecture.
  • Updates WSLc documentation with ARM64 build-path guidance.
File Description
scripts/​setup-wslc.ps1 Adds architecture-aware binary discovery.
tests/​scripts/​run_wslc_all_tests.ps1 Selects host-target test binary.
tests/​scripts/​run_wslc_state_aware_tests.ps1 Selects host-target lifecycle binary.
tests/​scripts/​run_wslc_proxy_test.ps1 Adds architecture-aware discovery.
tests/​scripts/​run_wslc_object_test.ps1 Adds architecture-aware discovery.
tests/​scripts/​run_wslc_most_specific_test.ps1 Adds architecture-aware discovery.
tests/​scripts/​run_wslc_dotdot_alias_test.ps1 Adds architecture-aware discovery.
tests/​scripts/​run_wslc_denied_masking_test.ps1 Adds architecture-aware discovery.
docs/​wsl/​wslc-sdk-bindings.md Documents the ARM64 Cargo target.
docs/​wsl/​wsl-container-getting-started.md Explains architecture-specific output paths.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread scripts/setup-wslc.ps1
Comment thread tests/scripts/run_wslc_all_tests.ps1
Comment thread tests/scripts/run_wslc_denied_masking_test.ps1
Comment thread tests/scripts/run_wslc_dotdot_alias_test.ps1
Comment thread tests/scripts/run_wslc_most_specific_test.ps1
Comment thread tests/scripts/run_wslc_object_test.ps1
Comment thread tests/scripts/run_wslc_proxy_test.ps1
Comment thread tests/scripts/run_wslc_state_aware_tests.ps1
Comment thread docs/wsl/wsl-container-getting-started.md

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@jsidewhite

Copy link
Copy Markdown
Member

$DaemonExe = Join-Path (Split-Path -Parent $WxcExec) "wxc-wslc-daemon.exe"

Maybe makes more sense to calculate a $bin path instead of an $WxcExec path?


Refers to: tests/scripts/run_wslc_state_aware_tests.ps1:101 in cef5e60. [](commit_id = cef5e60, deletion_comment = False)

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment thread tests/scripts/run_wslc_all_tests.ps1
Copilot AI review requested due to automatic review settings September 21, 2026 23:49

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

The unresolved architecture-detection thread still applies because PROCESSOR_ARCHITECTURE can describe the PowerShell process rather than the host OS.

Get a fresh assessment by requesting another Copilot review.

Review effort: Balanced
Findings: None

Resolved since last review (1)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants