WSLC scripts and tests now check for ARM targets on ARM systems - #1221
Elliot (theelliotm) wants to merge 4 commits into
Conversation
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Host detection remains incorrect when PowerShell or Command Prompt runs under x86/x64 emulation on ARM64.
Get a fresh assessment by requesting another Copilot review.
Review effort: Balanced
Findings: 8
Open (9)
Detect host architecture via PROCESSOR_ARCHITEW6432 · New Detect host architecture via PROCESSOR_ARCHITEW6432 · New Detect host architecture via PROCESSOR_ARCHITEW6432 · New Detect host architecture via PROCESSOR_ARCHITEW6432 · New Detect host architecture via PROCESSOR_ARCHITEW6432 · New Detect host architecture via PROCESSOR_ARCHITEW6432 · New Detect host architecture via PROCESSOR_ARCHITEW6432 · New Detect host architecture via PROCESSOR_ARCHITEW6432 · New Handle ARM64 emulation in build.bat architecture detection · New
What changed in this PR
Updates WSLc tooling to locate ARM64 build outputs on ARM64 hosts.
Changes:
- Selects ARM64 or x64 Rust targets based on detected architecture.
- Updates WSLc documentation with ARM64 build-path guidance.
| File | Description |
|---|---|
scripts/setup-wslc.ps1 |
Adds architecture-aware binary discovery. |
tests/scripts/run_wslc_all_tests.ps1 |
Selects host-target test binary. |
tests/scripts/run_wslc_state_aware_tests.ps1 |
Selects host-target lifecycle binary. |
tests/scripts/run_wslc_proxy_test.ps1 |
Adds architecture-aware discovery. |
tests/scripts/run_wslc_object_test.ps1 |
Adds architecture-aware discovery. |
tests/scripts/run_wslc_most_specific_test.ps1 |
Adds architecture-aware discovery. |
tests/scripts/run_wslc_dotdot_alias_test.ps1 |
Adds architecture-aware discovery. |
tests/scripts/run_wslc_denied_masking_test.ps1 |
Adds architecture-aware discovery. |
docs/wsl/wslc-sdk-bindings.md |
Documents the ARM64 Cargo target. |
docs/wsl/wsl-container-getting-started.md |
Explains architecture-specific output paths. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The standard backend-validation dispatcher still rejects ARM64 WSLC runs before invoking the updated test suite.
Get a fresh assessment by requesting another Copilot review.
Review effort: Balanced
Findings: 1
Open (1)
Resolved since last review (9)
Detect host architecture via PROCESSOR_ARCHITEW6432 Detect host architecture via PROCESSOR_ARCHITEW6432 Detect host architecture via PROCESSOR_ARCHITEW6432 Detect host architecture via PROCESSOR_ARCHITEW6432 Detect host architecture via PROCESSOR_ARCHITEW6432 Detect host architecture via PROCESSOR_ARCHITEW6432 Detect host architecture via PROCESSOR_ARCHITEW6432 Detect host architecture via PROCESSOR_ARCHITEW6432 Handle ARM64 emulation in build.bat architecture detection
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The unresolved architecture-detection thread still applies because PROCESSOR_ARCHITECTURE can describe the PowerShell process rather than the host OS.
Get a fresh assessment by requesting another Copilot review.
Review effort: Balanced
Findings: None


📖 Description
Currently, WSLC scripts and tests hardcode the x86 target. ARM systems must manually pass WxcExecPath to circumvent error messages saying
wxc-exec.exe not found.This PR changes the scripts/tests so they check the processor architecture and use the appropriate target.
🔗 References
🔍 Validation
Ran all scripts manually on my ARM machine.
✅ Checklist
Cargo.lock, thedependency-feed-checkcheck passes (see docs/pull-requests.md)📋 Issue Type
Microsoft Reviewers: Open in CodeFlow