0.9: Honor inheritDefaultEnv on LXC, Bubblewrap, and Seatbelt by theelliotm · Pull Request #1195 · microsoft/mxc

Elliot (theelliotm) · 2026-09-17T00:46:05Z

📖 Description

The Linux and MacOS backends had no standard default environment. This PR gives all three the same schema-0.9 contract the Windows process container got in #1120, implemented per-backend:

An omitted process.env gets a default block of PATH, HOME, and TERM.
An explicitly empty process.env stays empty, distinct from omitted.
A supplied process.env is used verbatim.
inheritDefaultEnv layers a supplied environment over the default, with a caller entry replacing the same-named default rather than duplicating it.

PATH is per-OS: Seatbelt keeps its existing value, Linux gets the sbin directories. HOME is the resolved working directory, since the child runs as the launching uid and that user's real home is not reachable under the sandbox's filesystem policy. When no working directory resolves, LXC and Bubblewrap fall back to /tmp (both provide it writable and Bubblewrap mounts a fresh tmpfs); Seatbelt leaves HOME unset, because its profile is deny-default and grants /private/tmp only under guiAccess, so a shared fallback would be either unwritable or a preplant target.

Version gate

The gate is a normalized ExecutionRequest::default_env_compatibility, set by each exact-contract adapter (0.6/0.7/0.8 legacy, 0.9+ default block) alongside network_enforcement_compatibility. It is deliberately not read back from source_contract, which is external-JSON attribution that the typed SDK builder clears — so a typed SDK request built against an exact pre-0.9 contract keeps pre-0.9 behavior.

The Windows process container now reads the same field. It previously applied the 0.9 env states at every version; below 0.9 an explicitly empty process.env again resolves to the user profile block rather than to an empty one.

Scope

Behavior below 0.9 is unchanged on all four backends. IsolationSession and WSLc are not covered and are tracked separately.

Seatbelt's resolution lives in a new host-agnostic default_env module, since seatbelt_runner is target_os = "macos" and would otherwise be untested off a Mac.

🔗 References

Resolves #1153

Add default environment behavior across SDKs #1120 — the Windows ProcessContainer contract this mirrors
inheritDefaultEnv is not honored on IsolationSession or WSLc #1165 — inheritDefaultEnv on IsolationSession and WSLc, still open

🔍 Validation

Unit tests per backend for all four states plus the sub-0.9 passthrough
Windows coverage for the pre-0.9 empty-env path, and an exact pre-0.9 typed SDK request asserting the gate survives cleared source attribution
run_bwrap_environment_test.sh and run_lxc_env_09_test.sh, wired into the suite runners; run_seatbelt_environment_test.sh extended
cargo fmt --all -- --check
cargo clippy --workspace --all-targets -- -D warnings
cargo clippy for x86_64-unknown-linux-gnu and aarch64-apple-darwin
cargo test for the touched crates
node scripts/versioning/validate-configs.js

✅ Checklist

Signed the Contributor License Agreement
Linked to an issue
Updated documentation (if applicable)
Updated Copilot instructions (if build, architecture, or conventions changed)
If this PR changes Cargo.lock, the dependency-feed-check check passes (see docs/pull-requests.md)

📋 Issue Type

Bug fix
Feature
Task

Microsoft Reviewers: Open in CodeFlow

The Unix backends had no default environment: Bubblewrap supplied none at all, so `PATH` came from the shell's compiled-in default and a nightly run failed on RHEL 10 where that value omits the `sbin` directories. LXC and Seatbelt each had their own unrelated behavior. Gives all three the same schema-0.9 contract the Windows process container got in #1120, implemented per-backend: * An omitted `process.env` gets a default block of `PATH`, `HOME`, and `TERM`. * An explicitly empty `process.env` stays empty, distinct from omitted. * A supplied `process.env` is used verbatim. * `inheritDefaultEnv` layers a supplied environment over the default, with a caller entry replacing the same-named default rather than duplicating it. `PATH` is per-OS: Seatbelt keeps its existing value, Linux gets the `sbin` directories. `HOME` is the resolved working directory (else `/tmp`), since the child runs as the launching uid and that user's real home is not reachable under the sandbox's filesystem policy. Behavior below 0.9 is unchanged on all three. IsolationSession and WSLc are not covered and are tracked separately. Seatbelt's resolution lives in a new host-agnostic `default_env` module, since `seatbelt_runner` is `target_os = "macos"` and would otherwise be untested off a Mac. Tests * Unit tests per backend for all four states plus the sub-0.9 passthrough * `run_bwrap_environment_test.sh` and `run_lxc_env_09_test.sh`, wired into the suite runners; `run_seatbelt_environment_test.sh` extended * cargo fmt --all -- --check * cargo clippy --workspace --all-targets -- -D warnings * cargo clippy for x86_64-unknown-linux-gnu and aarch64-apple-darwin * cargo test for the touched crates * node scripts/versioning/validate-configs.js Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Conflict resolutions: - lxc_runner.rs: keep resolved_env(request) for the exec environment on top of main's ContainerFirewall/plan_network changes; take main's trimmed comments. - config_parser.rs: differential corpus inventory is (379, 355, 14) -- main's converged baseline plus the twelve 0.9 inheritDefaultEnv fixtures. - version-specific-parser-migration-inventory.md: match the new counts. - lxc-backend.md: keep main's rewrite and re-apply the 0.9 default-env section. - run_lxc_all_tests.sh: keep both new suites. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

The merge resolution rewrote the file with LF, which made it diff as 180 changed lines instead of the 18 that were actually added. main stores this file with CRLF; match it. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

azure-pipelines · 2026-09-17T00:46:14Z

Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run.

Copilot

🟡 Changes recommended

Default HOME can disagree with the actual working directory, and Seatbelt still injects or overwrites PWD for supposedly empty or verbatim environments.

Get a fresh assessment by requesting another Copilot review.

Pull request overview

Standardizes schema-0.9 default environment handling across LXC, Bubblewrap, and Seatbelt.

Changes:

Adds backend-specific PATH, HOME, and TERM defaults with inheritance handling.
Adds unit and end-to-end coverage for all environment modes.
Documents the new behavior and updates parser fixtures.

File summaries

File	Description
`tests/scripts/run_seatbelt_environment_test.sh`	Extends Seatbelt environment tests.
`tests/scripts/run_lxc_env_09_test.sh`	Adds LXC environment tests.
`tests/scripts/run_lxc_all_tests.sh`	Registers the LXC test.
`tests/scripts/run_bwrap_environment_test.sh`	Adds Bubblewrap environment tests.
`tests/scripts/run_bwrap_all_tests.sh`	Registers the Bubblewrap test.
`tests/configs/seatbelt_env_09_verbatim.json`	Tests verbatim Seatbelt environment.
`tests/configs/seatbelt_env_09_inherit.json`	Tests Seatbelt inheritance.
`tests/configs/seatbelt_env_09_empty.json`	Tests empty Seatbelt environment.
`tests/configs/seatbelt_env_09_default_block.json`	Tests Seatbelt defaults.
`tests/configs/lxc_env_09_verbatim.json`	Tests verbatim LXC environment.
`tests/configs/lxc_env_09_inherit.json`	Tests LXC inheritance.
`tests/configs/lxc_env_09_empty.json`	Tests empty LXC environment.
`tests/configs/lxc_env_09_default_block.json`	Tests LXC defaults.
`tests/configs/bwrap_env_09_verbatim.json`	Tests verbatim Bubblewrap environment.
`tests/configs/bwrap_env_09_inherit.json`	Tests Bubblewrap inheritance.
`tests/configs/bwrap_env_09_empty.json`	Tests empty Bubblewrap environment.
`tests/configs/bwrap_env_09_default_block.json`	Tests Bubblewrap defaults.
`src/core/wxc_common/src/models.rs`	Updates environment semantics documentation.
`src/core/wxc_common/src/config_parser.rs`	Updates parser inventory counts.
`src/Cargo.lock`	Records added `semver` dependencies.
`src/backends/seatbelt/common/src/seatbelt_runner.rs`	Applies resolved Seatbelt environments.
`src/backends/seatbelt/common/src/lib.rs`	Exposes the environment module.
`src/backends/seatbelt/common/src/default_env.rs`	Implements Seatbelt defaults and merging.
`src/backends/seatbelt/common/Cargo.toml`	Adds `semver`.
`src/backends/lxc/common/src/lxc_runner.rs`	Implements LXC defaults and merging.
`src/backends/lxc/common/Cargo.toml`	Adds `semver`.
`src/backends/bubblewrap/common/src/bwrap_command.rs`	Implements Bubblewrap defaults and merging.
`docs/version-specific-parser-migration-inventory.md`	Updates fixture totals.
`docs/seatbelt/seatbelt-backend.md`	Documents Seatbelt environment behavior.
`docs/lxc-support/lxc-backend.md`	Documents LXC environment behavior.
`docs/bwrap-support/bubblewrap-backend.md`	Documents Bubblewrap environment behavior.

Review details

Files reviewed: 30/31 changed files
Comments generated: 4
Review effort level: Balanced

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

The three 0.9 environment suites asserted PATH=[] for the two cases that supply no PATH. A shell started without a PATH assigns its own compiled-in fallback, so \ reports the shell's default rather than what MXC passed and is never empty. On Debian that fallback is byte-for-byte the Linux default block, and lxc-attach injects the same string into every process it attaches, so neither its presence nor its absence proved anything. macOS /bin/sh fabricates TERM=dumb the same way. Assert HOME and TERM instead -- neither is fabricated, and both would be set had the default block been applied. That resolved_env is exactly empty is already asserted directly by the per-backend unit tests, which read the environment MXC builds rather than the child's view of it. Also make the host-leak assertions real: the 0.9 fixtures never echoed MXC_LEAK_PROBE, so grepping the output for its value could never match and the assertions passed vacuously. The fixtures now print it, which also distinguishes a shell-fabricated TERM from an inherited one. The inherit fixtures override TERM with vt100 rather than dumb so the override is distinguishable from the macOS shell default. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

…ATH-behavior

Copilot

🟡 Changes recommended

Relative working directories can produce incorrect HOME values across all three updated backends.

Get a fresh assessment by requesting another Copilot review.

Review details

Suppressed comments (3)

src/backends/bubblewrap/common/src/bwrap_command.rs:592

process.cwd is allowed to be relative. For cwd: "work", this sets HOME=work, while build_args subsequently changes into work; inside the child, $HOME then resolves to work/work rather than the working directory promised by this default. Derive HOME from the effective absolute sandbox cwd (or pass the final chdir path into this resolver), and cover the relative-cwd case.

    let home = request
        .resolved_working_directory()
        .map(|dir| dir.path.to_string())
        .unwrap_or_else(|| FALLBACK_HOME.to_string());

src/backends/lxc/common/src/lxc_runner.rs:55

A relative process.cwd is copied into HOME unchanged, but lxc-attach later executes cd work before starting the workload. Consequently $HOME=work resolves to a nested work/work path from the child's actual cwd instead of naming that cwd as documented. Resolve the effective absolute container cwd once and use it for both the attach command and this default.

    let home = request
        .resolved_working_directory()
        .map(|dir| dir.path.to_string())
        .unwrap_or_else(|| FALLBACK_HOME.to_string());

src/backends/seatbelt/common/src/default_env.rs:42

This uses the generic, unnormalized resolver, while seatbelt_runner separately expands ~ and (for the open path) anchors relative cwd values. Thus a cwd such as work or a ~/... policy fallback can leave HOME relative/unexpanded even though the child runs in a different normalized directory, breaking tools that use $HOME. Pass the runner's effective normalized cwd into environment resolution so both values agree.

    let home = request
        .resolved_working_directory()
        .map(|dir| dir.path.to_string())
        .unwrap_or_else(|| FALLBACK_HOME.to_string());

Files reviewed: 30/31 changed files
Comments generated: 1
Review effort level: Balanced

…ATH explicitly sets always overwrites the baseline

Copilot

🔵 Needs a closer look

Relative process.cwd values produce an incorrect relative HOME across all three updated backends.

Review details

Suppressed comments (3)

Previously missed (3) — in code that hasn't changed since the last review.

src/backends/bubblewrap/common/src/bwrap_command.rs:603

A relative process.cwd is copied directly into HOME. After Bubblewrap applies --chdir work, HOME=work resolves relative to the new directory (for example, as work/work) instead of naming the directory where the child actually runs. Resolve the cwd to the same absolute target used by --chdir, or reject relative cwd values before constructing the default block.
src/backends/lxc/common/src/lxc_runner.rs:66
start_directory can return a relative process.cwd, so this sets HOME to that raw relative string. The attach wrapper first changes into that directory; from inside the child, HOME=work then refers to a nested work/work path rather than the actual working directory. Resolve the cwd against the same container-side base used by attach_run (or set HOME after the wrapper's cd) before building the default environment.
src/backends/seatbelt/common/src/seatbelt_runner.rs:244
A relative process.cwd is passed through unchanged here. Command::current_dir("work") resolves it against the launcher directory, but the child receives HOME=work; after the chdir, that value resolves to <launcher>/work/work, not the directory where the child is running. This also makes the exec path differ from spawn_open, which already anchors relative paths. Anchor the resolved cwd once before using it for both current_dir and resolved_env.

Files reviewed: 30/31 changed files
Comments generated: 0 new
Review effort level: Balanced

Copilot

🔵 Needs a closer look

Relative working directories produce incorrect HOME values, and Seatbelt still injects or overwrites PWD in supposedly empty or verbatim environments.

Review details

Suppressed comments (4)

Previously missed (3) — in code that hasn't changed since the last review.

src/backends/bubblewrap/common/src/bwrap_command.rs:603

A relative process.cwd is copied directly into HOME, but --chdir changes the process directory before launch. For cwd: "work", HOME=work then resolves beneath the new directory rather than naming it, contrary to this function's contract. Normalize the actual target to an absolute path or reject relative cwd before building the environment.
src/backends/lxc/common/src/lxc_runner.rs:66
Using the raw relative cwd as HOME does not make HOME name the directory entered by the wrapper. With cwd: "work", the wrapper first changes into work, after which HOME=work refers to a nested work/work path. Resolve the container-relative target to an absolute path, or reject relative cwd before constructing the default environment.
src/backends/seatbelt/common/src/seatbelt_runner.rs:243
A relative process.cwd makes the new HOME point somewhere different from the actual working directory. For example, cwd: "work" is resolved by Command::current_dir against the launcher directory, but this passes HOME=work; once the child is in <launcher>/work, HOME resolves as <launcher>/work/work. Anchor the value before passing it to resolved_env, or reject relative cwd before applying this contract.

src/backends/seatbelt/common/src/seatbelt_runner.rs:256

The final Seatbelt environment is still not verbatim for schema 0.9: after apply_clean_environment handles env: [] or a supplied block, this unconditionally adds PWD and overwrites any caller-provided PWD. That contradicts the stated empty/verbatim contract. Either gate this legacy workaround for the 0.9 explicit modes or explicitly reserve and document PWD and adjust the contract/tests.

    let cwd = resolved_cwd.unwrap_or_else(|| UNRESOLVED_WORKING_DIRECTORY.to_string());
    command.current_dir(&cwd);
    command.env("PWD", &cwd);

Files reviewed: 30/31 changed files
Comments generated: 0 new
Review effort level: Balanced

Copilot

🟢 Approval recommended

The implementation consistently preserves version boundaries, applies the four-state contract across all scoped backends, and includes focused unit, integration, and documentation updates.

Review details

Files reviewed: 30/31 changed files
Comments generated: 0 new
Review effort level: Balanced

…it also has a bash-supplied fallback.

Copilot

🔵 Needs a closer look

Relative working directories produce incorrect relative HOME values across all three backends.

Review details

Suppressed comments (4)

Previously missed (4) — in code that hasn't changed since the last review.

src/backends/bubblewrap/common/src/bwrap_command.rs:603

A relative process.cwd is copied directly into HOME. Bubblewrap resolves --chdir within the sandbox, but the resulting child cwd is absolute; leaving HOME relative means shell ~ expansion points below that cwd instead of back to it. Normalize the sandbox start directory to the absolute path used by --chdir before using it as HOME, and test a relative cwd.
src/backends/lxc/common/src/lxc_runner.rs:66
start_directory may be relative, so this sets a relative HOME even though lxc-attach resolves cd "$1" from its container start directory. For cwd: "work", the process starts in /work but HOME=work, causing ~ to resolve as /work/work. Resolve the in-container cwd to the same absolute path used by the attach command before deriving HOME, and add a relative-cwd test.
src/backends/seatbelt/common/src/seatbelt_runner.rs:243
A relative process.cwd is passed directly as the default HOME. The exec path resolves that cwd relative to the launcher when current_dir runs, so the child starts in an absolute directory but receives a relative HOME (for example, cwd: "work" yields HOME=work, making ~ resolve below the cwd rather than to it). Anchor the cwd with the existing absolute_working_directory helper before passing it to both environment resolution and current_dir, and cover the relative-cwd case.
docs/seatbelt/seatbelt-backend.md:442
Correct the typo “ons” to “on”.

Files reviewed: 30/31 changed files
Comments generated: 0 new
Review effort level: Balanced

Copilot

Copilot review overview

🟡 Changes recommended

All three implementations reference a nonexistent ExecutionRequest::schema_version field, and Bubblewrap also lacks the declared semver dependency.

Get a fresh assessment by requesting another Copilot review.

Review effort: Balanced
Findings: 3

Open (3)

Fix schema_version access and undeclared semver dependency · New
Use source_contract instead of nonexistent schema_version · New
Gate on exact source_contract versions · New

Soham Das (SohamDas2021) · 2026-09-22T18:19:13Z

+pub const DEFAULT_SANDBOX_PATH: &str = "/usr/bin:/bin:/usr/sbin:/sbin";
+
+/// `HOME` when the request resolves no working directory.
+pub const FALLBACK_HOME: &str = "/tmp";


The generated profile is deny default and only grants /private/tmp under guiAccess, so without GUI access a workload that writes anything under $HOME gets EPERM, and with it HOME points at shared host /private/tmp, where another local user can preplant .npmrc/.gitconfig/.ssh/config that the sandbox then reads.

Suggest a per-run mode-0700 directory granted explicitly in the profile, plus a non-GUI test that writes under $HOME.

Going to simply omit HOME when cwd doesn't resolve.

Soham Das (SohamDas2021) · 2026-09-22T18:21:39Z

+/// takes the default, `[]` is empty, a supplied environment is used verbatim,
+/// and `inheritDefaultEnv` layers a supplied environment over the default.
+/// Below 0.9 the caller's entries are passed through untouched.
+fn resolved_env(request: &ExecutionRequest) -> Vec<String> {


[Follow-up] This function is identical to lxc_runner.rs:82 and seatbelt/default_env.rs:60. With Windows that's four copies of one contract.

Not in this PR, but file a follow-up ADO task to refactor and share? Do not file any more gh issues for now.

They now share properly.

Soham Das (SohamDas2021) · 2026-09-22T18:29:10Z

+/// `HOME` names the directory the child actually runs in, so it is a path the
+/// container has rather than a host path that was never mounted. With no start
+/// directory it is [`FALLBACK_HOME`], which every image provides writable.
+fn default_env(request: &ExecutionRequest) -> Vec<(String, String)> {


process.cwd may be relative, right? This copies the raw string into HOME. Same issue on Seatbelt runner. We should resolve to the absolute launch path

Soham Das (SohamDas2021) · 2026-09-22T18:31:11Z

+            let mut entries = default_env(request);
+            // A caller entry replaces the same-named default rather than
+            // being appended: `--setenv` would otherwise be passed twice.
+            for (key, value) in supplied.iter().filter_map(|kv| kv.split_once('=')) {


filter_map(split_once('=')) silently drops an entry with no =, so inheritDefaultEnv: true with ["FEATURE_FLAG"] loses it with no diagnostic and the path at :594 passes that same entry straight through. The two modes disagree on identical input. Either reject malformed entries at validation with a clear message or handle them identically in both paths.

Lifted to default_env.rs

Copilot

Copilot review overview

🟡 Changes recommended

Exact pre-0.9 Rust SDK requests incorrectly receive the new 0.9 default environment because source attribution is used as the compatibility gate.

Get a fresh assessment by requesting another Copilot review.

Review effort: Balanced
Findings: 1

Open (1)

Preserve selected contract version for pre-0.9 SDK requests · New

Resolved since last review (3)

Gate on exact source_contract versions
Use source_contract instead of nonexistent schema_version
Fix schema_version access and undeclared semver dependency

…ATH-behavior

Copilot

Copilot review overview

🟡 Changes recommended

Seatbelt’s fallback HOME is inaccessible under its default profile, and all added fixtures reference a nonexistent schema path.

Get a fresh assessment by requesting another Copilot review.

Review effort: Balanced
Findings: 1 · 12

Open (13)

Fallback HOME points to an ungranted Seatbelt path · New
$schema URI points to nonexistent schema file · New
$schema URI points to nonexistent schema file · New
$schema URI points to nonexistent schema file · New
$schema URI points to nonexistent schema file · New
$schema URI points to nonexistent schema file · New
$schema URI points to nonexistent schema file · New
$schema URI points to nonexistent schema file · New
$schema URI points to nonexistent schema file · New
$schema URI points to nonexistent schema file · New
$schema URI points to nonexistent schema file · New
$schema URI points to nonexistent schema file · New
$schema URI points to nonexistent schema file · New

Resolved since last review (1)

Preserve selected contract version for pre-0.9 SDK requests

Copilot

Copilot review overview

🟡 Changes recommended

The Seatbelt macOS test references an undefined constant, and the documented shared contract conflicts with the implemented Seatbelt fallback.

Get a fresh assessment by requesting another Copilot review.

Review effort: Balanced
Findings: 1 · 1

Open (2)

Fix macOS test referencing nonexistent FALLBACK_HOME · New
Clarify Seatbelt environment behavior and /tmp fallback contract · New

Resolved since last review (13)

Fallback HOME points to an ungranted Seatbelt path
$schema URI points to nonexistent schema file
$schema URI points to nonexistent schema file
$schema URI points to nonexistent schema file
$schema URI points to nonexistent schema file
$schema URI points to nonexistent schema file
$schema URI points to nonexistent schema file
$schema URI points to nonexistent schema file
$schema URI points to nonexistent schema file
$schema URI points to nonexistent schema file
$schema URI points to nonexistent schema file
$schema URI points to nonexistent schema file
$schema URI points to nonexistent schema file

Previously missed (1)

In code that hasn't changed since last review

Update SDK documentation for non-empty default environment blocks

src/core/mxc_engine/src/policy.rs:899

The newly asserted non-empty defaults make the public Rust SDK documentation stale: SandboxRequest::inherit_default_env still says it is equivalent to set_env on LXC, Bubblewrap, and Seatbelt (policy.rs:677-678). That is now false from 0.9 and can cause callers to omit required inheritance. Update that API documentation to describe these new default blocks.

Copilot

Copilot review overview

🟡 Changes recommended

The public Rust SDK documentation still incorrectly describes the affected backends as having empty default environments.

Get a fresh assessment by requesting another Copilot review.

Review effort: Balanced
Findings: 1

Open (1)

Update rustdoc for changed LXC/Bubblewrap/Seatbelt defaults · New

Resolved since last review (2)

Fix macOS test referencing nonexistent FALLBACK_HOME
Clarify Seatbelt environment behavior and /tmp fallback contract

Copilot

Copilot review overview

🔵 Needs a closer look

Cross-platform process-launch semantics and host-specific integration behavior require final human validation.

Review effort: Balanced
Findings: None

Resolved since last review (1)

Update rustdoc for changed LXC/Bubblewrap/Seatbelt defaults

Copilot

Copilot review overview

🔵 Needs a closer look

Cross-platform process-launch semantics and version compatibility require final human validation despite comprehensive coverage.

Review effort: Balanced
Findings: None

Elliot (theelliotm) and others added 3 commits September 14, 2026 17:40

Copilot AI balanced review requested due to automatic review settings September 17, 2026 00:46

Copilot started reviewing on behalf of Elliot (theelliotm) September 17, 2026 00:46 View session

Copilot AI reviewed Sep 17, 2026

View reviewed changes

Comment thread src/backends/bubblewrap/common/src/bwrap_command.rs Outdated

Comment thread src/backends/lxc/common/src/lxc_runner.rs

Comment thread src/backends/seatbelt/common/src/default_env.rs Outdated

Comment thread src/backends/seatbelt/common/src/seatbelt_runner.rs

Elliot (theelliotm) and others added 2 commits September 17, 2026 11:28

Merge remote-tracking branch 'origin' into user/emichlin/consistent-P…

bf49073

…ATH-behavior

Copilot AI review requested due to automatic review settings September 17, 2026 20:08

Copilot started reviewing on behalf of Elliot (theelliotm) September 17, 2026 20:09 View session

Copilot AI reviewed Sep 17, 2026

View reviewed changes

Comment thread docs/lxc-support/lxc-backend.md

HOME now is the path the child started in, and tests now check that P…

75746b2

…ATH explicitly sets always overwrites the baseline

Copilot AI review requested due to automatic review settings September 17, 2026 20:41

Copilot started reviewing on behalf of Elliot (theelliotm) September 17, 2026 20:42 View session

Copilot AI reviewed Sep 17, 2026

View reviewed changes

fix clippy issue

3e36713

Copilot AI review requested due to automatic review settings September 17, 2026 20:50

Copilot started reviewing on behalf of Elliot (theelliotm) September 17, 2026 20:50 View session

Copilot AI reviewed Sep 17, 2026

View reviewed changes

Updated documentation

2bb410f

Copilot AI review requested due to automatic review settings September 17, 2026 21:11

Copilot started reviewing on behalf of Elliot (theelliotm) September 17, 2026 21:11 View session

Copilot AI reviewed Sep 17, 2026

View reviewed changes

bubblewrap tests no longer assert TERM is empty (just different), as …

f7c80b2

…it also has a bash-supplied fallback.

Copilot AI review requested due to automatic review settings September 17, 2026 22:54

Copilot started reviewing on behalf of Elliot (theelliotm) September 17, 2026 22:54 View session

Copilot AI reviewed Sep 17, 2026

View reviewed changes

Elliot (theelliotm) marked this pull request as ready for review September 18, 2026 00:14

Elliot (theelliotm) requested a review from a team September 18, 2026 00:14

Copilot AI review requested due to automatic review settings September 22, 2026 17:55

Copilot started reviewing on behalf of Elliot (theelliotm) September 22, 2026 18:00 View session

Copilot AI reviewed Sep 22, 2026

View reviewed changes

Comment thread src/backends/bubblewrap/common/src/bwrap_command.rs Outdated

Comment thread src/backends/lxc/common/src/lxc_runner.rs Outdated

Comment thread src/backends/seatbelt/common/src/default_env.rs Outdated

Soham Das (SohamDas2021) reviewed Sep 22, 2026

View reviewed changes

ContractVersion is now used to check if inheritDefaultEnv is checked.

6bbf361

Copilot AI review requested due to automatic review settings September 22, 2026 22:25

Copilot started reviewing on behalf of Elliot (theelliotm) September 22, 2026 22:26 View session

Copilot AI reviewed Sep 22, 2026

View reviewed changes

Comment thread src/core/wxc_common/src/models.rs Outdated

Elliot (theelliotm) added 2 commits September 22, 2026 16:22

Merge remote-tracking branch 'origin' into user/emichlin/consistent-P…

c8b1d8e

…ATH-behavior

default_env_compatibility now establishes compat for all backends

278fe77

Copilot AI review requested due to automatic review settings September 22, 2026 23:28

Copilot started reviewing on behalf of Elliot (theelliotm) September 22, 2026 23:29 View session

Copilot AI reviewed Sep 22, 2026

View reviewed changes

addressing feedback

21769c1

Copilot AI review requested due to automatic review settings September 23, 2026 00:13

Copilot started reviewing on behalf of Elliot (theelliotm) September 23, 2026 00:14 View session

Copilot AI reviewed Sep 23, 2026

View reviewed changes

Comment thread src/backends/seatbelt/common/src/seatbelt_runner.rs

Comment thread src/core/wxc_common/src/models.rs Outdated

Fix FALLBACK HOME leftover usage

f71794e

Copilot AI review requested due to automatic review settings September 23, 2026 00:25

Copilot started reviewing on behalf of Elliot (theelliotm) September 23, 2026 00:25 View session

Copilot AI reviewed Sep 23, 2026

View reviewed changes

Comment thread src/core/wxc_common/src/models.rs

update rustdocs

6f401d1

Copilot AI review requested due to automatic review settings September 23, 2026 00:42

Copilot started reviewing on behalf of Elliot (theelliotm) September 23, 2026 00:42 View session

Elliot (theelliotm) requested a review from Soham Das (SohamDas2021) September 23, 2026 00:46

Copilot AI reviewed Sep 23, 2026

View reviewed changes

convert relative cwd to absolute when passing into HOME

cc22dac

Copilot AI review requested due to automatic review settings September 23, 2026 00:55

Copilot started reviewing on behalf of Elliot (theelliotm) September 23, 2026 00:56 View session

Copilot AI reviewed Sep 23, 2026

View reviewed changes

Conversation

Elliot (theelliotm) commented Sep 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📖 Description

Version gate

Scope

🔗 References

🔍 Validation

✅ Checklist

📋 Issue Type

Microsoft Reviewers: Open in CodeFlow

Uh oh!

azure-pipelines Bot commented Sep 17, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟡 Changes recommended

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟡 Changes recommended

Suppressed comments (3)

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🔵 Needs a closer look

Suppressed comments (3)

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🔵 Needs a closer look

Suppressed comments (4)

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟢 Approval recommended

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🔵 Needs a closer look

Suppressed comments (4)

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🟡 Changes recommended

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

Elliot (theelliotm) commented Sep 17, 2026 •

edited

Loading