Skip to content

Add support for osx-arm64 for Java and Rust - #8

Merged
Lakshya A Agrawal (LakshyAAAgrawal) merged 1 commit into
microsoft:mainfrom
mrT23:main
Dec 27, 2024
Merged

Add support for osx-arm64 for Java and Rust#8
Lakshya A Agrawal (LakshyAAAgrawal) merged 1 commit into
microsoft:mainfrom
mrT23:main

Conversation

@mrT23

@mrT23 Tal (mrT23) commented Oct 18, 2024

Copy link
Copy Markdown
Contributor

This PR extends the support of multispy for Java and Rust also to Mac computers

Example results

On Rust, for example, I tested it on the repo: https://github.com/rust-lang/rfcbot-rs

project_dir = workspace/rfcbot-rs-master'
rel_file = "src/config.rs"

Results:

================
For the file '/workspace/rfcbot-rs-master/src/config.rs', here are the files referenced by it (context):

/workspace/rfcbot-rs-master/src/macros.rs


================
For the file '/Users/talrid/Git/rfcbot-rs-master/src/config.rs', here are the files referencing it (reverse context):

/workspace/rfcbot-rs-master/src/scraper.rs
/workspace/rfcbot-rs-master/src/main.rs
/workspace/rfcbot-rs-master/src/github/command.rs
================

Related: #28

@mrT23

Copy link
Copy Markdown
Contributor Author

@microsoft-github-policy-service agree company="qodo"

@LakshyAAAgrawal

Lakshya A Agrawal (LakshyAAAgrawal) commented Oct 20, 2024

Copy link
Copy Markdown
Collaborator

Hi Tal (@mrT23) ,

Thanks a lot for the PR.

Could you please confirm if the changes are similar to the ones made at microsoft/monitors4codegen#18 by Haoxiang Fei (@tonyfettes)?

It seems to me that the 2 PRs are targetting different mac versions (intel vs M series macs, I believe). Could you please confirm that, and add documentation clarifying the same?

I will proceed with merging this immediately after merging #7.

Haoxiang Fei (@tonyfettes), I would be grateful if you could also provide your changes in microsoft/monitors4codegen#18 to multilspy!

@mrT23

Tal (mrT23) commented Oct 28, 2024

Copy link
Copy Markdown
Contributor Author

The PRs are similar. mine contains additional needed changes.

In addition, I ran and validated mine

image

@LakshyAAAgrawal

Copy link
Copy Markdown
Collaborator

Dear Tal (@mrT23), I apologize for getting back so late on this. I would be glad if you could reopen this PR, and I will proceed to work on it and merge it immediately.

@themichaelusa

Copy link
Copy Markdown
Contributor

Lakshya A Agrawal (@LakshyAAAgrawal) Can you merge this?

@LakshyAAAgrawal
Lakshya A Agrawal (LakshyAAAgrawal) merged commit c918061 into microsoft:main Dec 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants