You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
EfiDiagnostics: Define important MsvmPkg INFO logs - #126
OpenVMM and Hyper-V have a limitation where we cannot emit INFO logs by default through our tracing backends due to various reasons, most importantly regarding log output volume from upstream INFO logs.
We have thus previously agreed that we will only emit ERROR and WARN logs, but there are certain INFO logs that we need to guide us through what happened during boot for triage.
This PR defines the union of warn and info flags, DEBUG_WARN | DEBUG_INFO, as an EFI_DIAGNOSTICS_IMPORTANT_INFO log, which the platform VMM can handle to their liking.
I'm thinking we should probably define, in an EfiDiagnostics header, some constant for important logs. Which would be the union of DEBUG_WARN and DEBUG_INFO
I don't have any logs I would recommend. I think this approach is fine for platform code, I do think you should make sure to document this clearly because it is a different paradigm than any other logging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OpenVMM and Hyper-V have a limitation where we cannot emit INFO logs by default through our tracing backends due to various reasons, most importantly regarding log output volume from upstream INFO logs.
We have thus previously agreed that we will only emit ERROR and WARN logs, but there are certain INFO logs that we need to guide us through what happened during boot for triage.
This PR defines the union of warn and info flags,
DEBUG_WARN | DEBUG_INFO, as anEFI_DIAGNOSTICS_IMPORTANT_INFOlog, which the platform VMM can handle to their liking.