Open
Conversation
|
@Santhosha-bk please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
4 tasks
guhetier
reviewed
Apr 1, 2026
src/inc/quic_platform_winuser.h
Outdated
| NTSTATUS CancelStatus = NtCancelWaitCompletionPacket( | ||
| sqe->WaitCompletionPacket, // WaitCompletionPacketHandle | ||
| TRUE); // RemoveSignaledPacket | ||
| CXPLAT_DBG_ASSERT(NT_SUCCESS(CancelStatus)); |
Collaborator
There was a problem hiding this comment.
Tests show that assertion triggering.
Contributor
Author
There was a problem hiding this comment.
Removed assert as the failure is expected
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
CxPlatEventQEnqueue, aka PostQueuedCompletionStatus, can fail because of OOM. The reason for this is that NtSetIoCompletion underneath PQCS must allocate an IO completion packet to add to the target IOCP
Describe the purpose of and changes within this Pull Request.
Added a Wake Completion Packet (WCP) mechanism which will be used as a primary path for shutdownSqe and PQCS will be a backup mechanism.
Old PR #5617
#5369
Testing
Do any existing tests cover this change? Are new tests needed?
Documentation
Is there any documentation impact for this change?