[Will Hawkins (hawkinsw)]

In the ELF loader, support optionally initializing the stack with random padding bytes.

[Will Hawkins (hawkinsw)]

I think that Litebox is so cool! I noticed a TODO and thought I would take a crack at it! I tried to be a good citizen, but I am sure that I have missed something from the contributing guidelines in the PR. So, if there is anything I can do to improve it, please just let me know!

In particular, I chose:

• to use the getrandom crate because it was already used elsewhere in the project; and
• to surface the choice to override the default stack padding as high as possible to keep from introducing dependencies on external crates into the core libraries.

Again, if this change is something that is helpful but does not follow all the best practices, please let me know! I would love to clean it up.

Thanks again for this great effort!

[Will Hawkins (hawkinsw)]

Praveen K Paladugu (@praveen-pk) Thank you for triggering the CI run! Obviously there is a change in the publicly-visible interfaces. If that is okay, just let me know how to handle the semver check/changes.

If you would prefer to handle supporting randomized padding bytes without exposing the option to the user, that is absolutely ok! Just let me know how I can spruce up the PR!

Thank you again for tiggering the CI run!

[Praveen K Paladugu (praveen-pk)]

Will Hawkins (@hawkinsw), this PR looks good to me!

as to semver checks, I believe you only have to add some details to the commit message.

Jay Bosamiya (Microsoft) (@jaybosamiya-ms) could you please help with the semver failure on this PR?

[Jay Bosamiya (Microsoft) (jaybosamiya-ms)]

Thanks, some changes are needed before we can consider merging this, mostly we don't want to be pulling this in as a dependency in this crate. The semver failure, if it still remains, can be fixed right before we consider merging it, please don't worry about it. The Windows failure needs to be fixed in the code however.

[Will Hawkins (hawkinsw)]

Thank you Jay Bosamiya (Microsoft) (@jaybosamiya-ms) and Praveen K Paladugu (@praveen-pk) for the reviews! I am terribly sorry for the slow response! I should have an update today! Thank you for being so welcoming to a new contributor!

[Will Hawkins (hawkinsw)]

Jay Bosamiya (Microsoft) (@jaybosamiya-ms) Using the platform's fill_bytes_crng looks so much nicer! I hope that the updated PR was what you expected. Thanks again for letting me participate!