Repository navigation
Fix Go generation for nullable UUID path parameters - #8208
Conversation
Co-authored-by: baywet <7905502+baywet@users.noreply.github.com>
|
Thanks for opening this pull request! Please add a changelog entry under |
There was a problem hiding this comment.
🟢 Approval recommended
The fix is covered by regression tests with no unresolved blocking issues.
Pull request overview
Fixes invalid Go generation for nullable UUID path parameters.
Changes:
- Parenthesizes dereferenced UUID values before calling
String(). - Adds regression coverage, including escaped parameter names.
File summaries
| File | Description |
|---|---|
tests/Kiota.Builder.Tests/Writers/Go/GoConventionServiceTests.cs |
Adds regression assertions for generated output. |
src/Kiota.Builder/Writers/Go/GoConventionService.cs |
Corrects nullable UUID pointer conversion. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Code Coverage OverviewLanguages: C# C# / code-coverage/dotnetThe overall line coverage in commit 7be99cc in the Show a line coverage summary of the most covered files.
Updated |
|
Copilot add a changelog entry under unreleased changed section |
Co-authored-by: baywet <7905502+baywet@users.noreply.github.com>
bug uncovered by these changes microsoftgraph/msgraph-metadata#1209
Recent Dependabot PRs exposed a Graph beta metadata update that added
Edm.GuidgetByUseroverloads understorage.fileStorage. Go generation emitted invalid pointer dereferencing for nullable UUID path parameters.Guid/UUIDpointer values before callingString().