cherry-pick: gatekeeper: Add EditorConfig checker to required tests#446
cherry-pick: gatekeeper: Add EditorConfig checker to required tests#446sprt wants to merge 3 commits into
Conversation
sprt
changed the title
There was a problem hiding this comment.
Pull request overview
Updates gatekeeper’s required CI checks to ensure the EditorConfig workflow is enforced, and cleans up a formatting artifact in the security policy document.
Changes:
- Add the “EditorConfig checker / editorconfig-checker” GitHub Actions check to gatekeeper required tests.
- Fix a formatting/whitespace issue in
SECURITY.md.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tools/testing/gatekeeper/required-tests.yaml | Adds EditorConfig checker to the always-required CI checks enforced by gatekeeper. |
| SECURITY.md | Removes an apparent stray formatting marker and trailing whitespace to restore clean markdown formatting. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Now that it's stable and fully configured. Signed-off-by: Aurélien Bombo <abombo@microsoft.com>
Satistfy EditorConfig. Signed-off-by: Aurélien Bombo <abombo@microsoft.com>
These are useful when rebasing our fork as `git rebase -i --autosquash` will automatically squash such commits as documented in [1]. Not upstreamable as this would allow not-fully-baked PRs upstream. [1]: https://git-scm.com/docs/git-commit#Documentation/git-commit.txt---fixupamendrewordcommit Signed-off-by: Aurélien Bombo <abombo@microsoft.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 3 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
So, conceptually, these fixup! or amend! commits will be automatically squashed into the prior PRs at the point we merge this change? |
Rather: at the point we run the rebase command from the PR description. |
|
Not needed with latest rebase. |
Cherry-picking from upstream.
Cool note: I created the second commit with
git commit --fixup 4e81837so that on the next rebasegit rebase -i --autosquashwill automatically squash the new commit into the original SECURITY.md commit:https://blog.gitbutler.com/git-autosquash
https://git-scm.com/docs/git-commit#Documentation/git-commit.txt---fixupamendrewordcommit