Drop obsolete retain-build placeholder#2277
Merged
Merged
Conversation
The TODO comment was a marker that 1ES PT migration removed Arcade's retain-build step. The replacement is now in microsoft/go-infra's release pipeline (release-build-steps.yml, after wait-ci-trigger), which discovers the auto-triggered microsoft-go build and pins it externally. The microsoft-go pipeline itself can't gate retention because CI-triggered runs don't carry release parameters; the release pipeline is the only caller that knows it's a release. See microsoft/go-infra#480.
27ec2be to
b262e6d
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR cleans up the Azure DevOps pipeline stage template by removing obsolete, commented-out “retain build” placeholder logic in run-stage.yml, improving readability without changing behavior.
Changes:
- Removed commented-out conditional YAML that referenced retaining builds for the
buildandpackconfiguration whenreleaseVersionis set.
dagood
approved these changes
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request makes a minor change to the
eng/pipeline/stages/run-stage.ymlfile by removing commented-out code related to retaining builds for thebuildandpackconfiguration. This cleanup helps keep the pipeline YAML more readable and maintainable.buildandpackconfiguration and a non-nilreleaseVersion.