Update submodule to latest master in microsoft/main#2273
Merged
Conversation
![review-bot-for-go[bot]](https://avatars.githubusercontent.com/in/1212424?s=60&v=4){kind=small}
…DSO on linux/ppc64le
bot-for-go
Bot
force-pushed
the
dev/auto-sync/microsoft/main
branch
from
f7e38f9 to
a3e4b5b
Compare
gdams
approved these changes
May 12, 2026
qmuntal
approved these changes
May 12, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This upstream sync updates the patch set to apply cleanly on the latest microsoft/main (submodule master), adjusting the crypto backend and vendoring patches to match upstream file movements and dependency rules.
Changes:
- Refreshes the vendoring patch to newer dependency versions and updated
deps_test.go/vendor_test.gorules for additionalgithub.com/*vendored dependencies. - Updates the crypto backend implementation patch to match upstream
internal/buildcfg/exp.gochanges (notably moving system-crypto support detection tointernal/platformand expanding dependency rules). - Minor patch metadata/hunk offset updates (indexes/line numbers/stat lines) to keep the series applying cleanly.
Show a summary per file
| File | Description |
|---|---|
| patches/0001-Vendor-external-dependencies.patch | Updates external dependency versions and vendor-related rules, plus adjusts build import/deps tests to recognize new vendored module paths. |
| patches/0002-Add-crypto-backend-GOEXPERIMENTs.patch | Rebases GOEXPERIMENT/system crypto baseline handling on top of the updated upstream. |
| patches/0003-Implement-crypto-internal-backend.patch | Rebases the backend implementation and related deps/buildcfg changes to updated upstream structure. |
Copilot's findings
Comments suppressed due to low confidence (1)
patches/0001-Vendor-external-dependencies.patch:2405
- This vendor patch is modifying non-vendor Go source files (e.g., src/go/build/deps_test.go and src/go/build/vendor_test.go). Per the patch-series consistency rules, 0001-Vendor-external-dependencies.patch should be limited to vendor/ tree changes plus related module files (go.mod/go.sum/modules.txt) and src/crypto/internal/backend/deps_ignore.go. Please move these go/build test changes into the patch that introduces the crypto backend behavior (or another appropriately scoped patch) so the vendor patch remains vendor-only.
- Files reviewed: 4/4 changed files
- Comments generated: 1
Comment on lines
3397
to
3403
|
|
||
| // Older versions (anything before V16) of dsymutil don't handle | ||
| // the .debug_rnglists section in DWARF5. See | ||
| @@ -111,7 +103,7 @@ func ParseGOEXPERIMENT(goos, goarch, goexp string) (*ExperimentFlags, error) { | ||
| RandomizedHeapBase64: true, | ||
| GreenTeaGC: true, | ||
| GoroutineLeakProfile: true, | ||
| - SystemCrypto: systemCryptoSupported, | ||
| + SystemCrypto: systemCryptoSupported, // if system crypto is supported, enable it by default | ||
| } | ||
| flags := &ExperimentFlags{ | ||
| Flags: baseline, | ||
| @@ -160,6 +152,16 @@ func ParseGOEXPERIMENT(goos, goarch, goexp string) (*ExperimentFlags, error) { | ||
| @@ -159,6 +151,16 @@ func ParseGOEXPERIMENT(goos, goarch, goexp string) (*ExperimentFlags, error) { | ||
| if strings.HasPrefix(f, "no") { | ||
| f, val = f[2:], false | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi! I'm a bot, and this is an automatically generated upstream sync PR. 🔃
After submitting the PR, I will attempt to enable auto-merge in the "merge commit" configuration.
For more information, visit sync documentation in microsoft/go-infra.