Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to stop the AOF streaming BulkConsumeAllAsync loop when the replica client connection is no longer healthy, by introducing a stopConsume callback that can terminate consumption without running a separate monitoring task.
Changes:
- Added an optional
stopConsumecallback parameter toTsavoriteLogScanIterator.BulkConsumeAllAsync. - Wired
stopConsumeinto the primary-side AOF sync task to stop streaming whenGarnetClientSessiondisconnects. - Updated the replica replay task call site to accommodate the new method signature.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| libs/storage/Tsavorite/cs/src/core/TsavoriteLog/TsavoriteLogIterator.cs | Adds stopConsume callback support to the bulk consume loop. |
| libs/cluster/Server/Replication/PrimaryOps/AofSyncTaskInfo.cs | Uses stopConsume to exit AOF streaming when the client disconnects. |
| libs/cluster/Server/Replication/ReplicaOps/ReplicaReplayTask.cs | Updates BulkConsumeAllAsync invocation to match the new signature. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
libs/storage/Tsavorite/cs/src/core/TsavoriteLog/TsavoriteLogIterator.cs
Outdated
Show resolved
Hide resolved
libs/storage/Tsavorite/cs/src/core/TsavoriteLog/TsavoriteLogIterator.cs
Outdated
Show resolved
Hide resolved
libs/storage/Tsavorite/cs/src/core/TsavoriteLog/TsavoriteLogIterator.cs
Outdated
Show resolved
Hide resolved
libs/cluster/Server/Replication/ReplicaOps/ReplicaReplayTask.cs
Outdated
Show resolved
Hide resolved
0799aaf to
190dd34
Compare
badrishc
reviewed
Apr 2, 2026
f7985c6 to
0335ff2
Compare
badrishc
approved these changes
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a stopConsume callback that checks the health of the client connection when streaming the AOF.
I used a callback here to avoid maintaining a second background task that monitors the connection and kills the AOF BulkConsume loop.