[Ray Winkelman (rwinkelman)]

Summary

`useKeytipsManager` only subscribed to `KEYTIP_ADDED`, so the registry grew unbounded. Subscribe to `KEYTIP_UPDATED` and `KEYTIP_REMOVED` as `useKeytips` already does.

Fixes #671

Test plan

• Register then unregister a keytip; `getKeytips()` no longer contains it
• Update a keytip; registry reflects new props

[Paul Mardling (PaulGMardling)]

This looks like a focused fix that keeps the manager’s registry consistent with update and removal events.

Could we also add a useKeytipsManager regression test that registers a keytip, updates it and checks the new properties through getKeytips(), then unregisters it and checks that the entry is gone?

That would directly cover the stale-registry behavior this fixes.

[Ray Winkelman (rwinkelman)]

Added useKeytipsManager coverage that registers a keytip, updates it, and checks the new content through getKeytips(), then unregisters it and checks the entry is gone.

yarn nx test react-keytips passed locally, including useKeytipsManager.test.ts.

[Paul Mardling (PaulGMardling)]

Looks good to me. The new test covers the registry update and removal behavior we discussed. Thanks for adding it!

[Martin Hochel (Hotell)]

Victor Genaev (@mainframev), the fix looks good, can you please double check and merge if all good ?

[Dmytro Kirpa (dmytrokirpa)]

nit

Suggested change

	"comment": "fix(react-keytips): handle KEYTIP_REMOVED/UPDATED in useKeytipsManager",
	"comment": "fix: handle KEYTIP_REMOVED/UPDATED in useKeytipsManager",