Repository navigation
Fix catalog CodeQL upload conflict with default setup - #239
Open
yousefi-msft wants to merge 1 commit into
Open
yousefi-msft wants to merge 1 commit into
yousefi-msft wants to merge 1 commit into
Conversation
Retain catalog-scoped analysis and SARIF artifacts without submitting advanced CodeQL results while default setup is enabled. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Prevent the catalog CodeQL workflow from submitting advanced-configuration SARIF while repository CodeQL default setup is enabled. Keep the catalog-scoped analysis and unconditional downloadable SARIF artifact, update the explanatory workflow comments, and lock the behavior with a regression assertion.
Type of change
agents/<name>/)starter-kits/<name>/)docs/schemas/**).github/**)Related issue / tracking
Refs https://github.com/microsoft/discovery/actions/runs/38660892813/job/116185358442 (run triggered by #163).
Schema impact
breaking-changelabel and link the rollout plan belowValidation checklist
README.md, schemas) is updated to match the change..auto-registry/**(it is generated post-merge)..DS_Store,.env,*.swp,.idea/,.vs/, etc.).Reviewer notes (optional)
The failed run completed analysis, then GitHub rejected processing with: "CodeQL analyses from advanced configurations cannot be processed when the default setup is enabled". This change disables only that incompatible CodeQL upload, not analysis or artifact retention. Existing PR reporting and push/scheduled error behavior are unchanged. Workflow comments document the reporting destination; no schemas or model weights change.
Validation:
python -m pytest .github\tests\test_security_automation.py .github\tests\test_validate_pr_pol021.py -q— passed, 68 tests.git diff --check— passed before commit.The pre-existing ZINC parse diagnostic in the failed run is separate from the upload failure and is intentionally unchanged.