Replace websocket with ws to eliminate es5-ext dependency#633
Draft
jiridanek wants to merge 1 commit intomicrosoft:mainfrom
Draft
Replace websocket with ws to eliminate es5-ext dependency#633jiridanek wants to merge 1 commit intomicrosoft:mainfrom
jiridanek wants to merge 1 commit intomicrosoft:mainfrom
Conversation
The websocket package (theturtle32/WebSocket-Node) depends on es5-ext, which is quarantined. ws is the modern, actively maintained alternative with 86M weekly downloads and zero es5-ext dependency. This is a draft to start the conversation about the longer-term fix. Source code changes to adapt to the ws API are needed. Ref: microsoft#420 Co-authored-by: Cursor <cursoragent@cursor.com>
Author
|
@microsoft-github-policy-service agree company="Red Hat" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
websocketpackage (theturtle32/WebSocket-Node) depends ones5-ext, which is quarantined by Nexus Firewall (sonatype-2022-2248). Thewebsocketpackage has an open PR to drop es5-ext but it has been unreviewed for 9 months.This PR proposes replacing
websocket@^1.0.28withws@^8.18.0, the modern, actively maintained WebSocket implementation for Node.js (86M weekly downloads, zeroes5-extdependency).Note: This is a draft to start the conversation. The
wspackage has a different API surface fromwebsocket, so source code changes in the connections module would be needed. The immediate fix is in the companion PR that removes the directes5-extdep and adds an npm override.Ref: #420
References
wson npm — 86M weekly downloads, MIT licenseMade with Cursor