fix: hide scrollbar in dropdown popup on Linux GTK#275
Open
Jah-yee wants to merge 1 commit into
Open
Conversation
The ScrolledComposite in DropdownPopup always shows a scrollbar on Linux GTK even when content fits, causing hover tooltips to be cropped. Setting alwaysShowScrollBars(false) ensures the scrollbar only appears when truly needed. Fixes microsoft#113
Jah-yee
requested review from
duzitong,
ethanyhou,
jdneo and
xinyi-gong
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
This PR updates the SWT dropdown popup’s scrolled container configuration to improve scrollbar visibility/behavior.
Changes:
- Disable always-on scrollbars for the dropdown’s
ScrolledComposite.
| scrolledComposite.setLayoutData(new GridData(SWT.FILL, SWT.FILL, true, true)); | ||
| scrolledComposite.setExpandHorizontal(true); | ||
| scrolledComposite.setExpandVertical(true); | ||
| scrolledComposite.setAlwaysShowScrollBars(false); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #113
Problem
On Linux GTK, the ScrolledComposite in DropdownPopup always renders a scrollbar
even when all content fits within the visible area. This causes detailed model
information displayed on hover tooltips to be cropped, as the scrollbar overlay
interferes with the rendering of hover content.
Fix
Added after creating the
ScrolledComposite in the constructor. This matches the pattern already used in
(line 258) and (line 119) in the same codebase.
Testing