Repository navigation
Swift Experimental=>Default-On - #1900
Merged
Ryan Brandenburg (ryanbrandenburg) merged 1 commit intoOct 20, 2026
Merged
Conversation
Ryan Brandenburg (ryanbrandenburg)
requested a review
from a team
as a code owner
October 19, 2026 22:31
Ryan Brandenburg (ryanbrandenburg)
requested review from
Jamie Magee (JamieMagee)
and
a balanced review from Copilot
October 19, 2026 22:31
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Snapshot verification needs to handle Swift dependency graphs absent from experimental baselines.
1 open issue
What changed in this PR
Promotes Swift Package Manager detection to default-on, including discovered dependencies in normal scan results.
Changes:
- Removes Swift’s experimental status and experiment registration.
- Updates lifecycle tests and removes obsolete experiment tests.
- Documents Swift detection as stable and enabled by default.
| File | Description |
|---|---|
| test/Microsoft.ComponentDetection.Orchestrator.Tests/Experiments/SwiftDetectorExperimentTests.cs | Removes obsolete experiment tests. |
| test/Microsoft.ComponentDetection.Orchestrator.Tests/Experiments/ExperimentServiceTests.cs | Removes Swift-specific experiment scenarios. |
| test/Microsoft.ComponentDetection.Orchestrator.Tests/Experiments/ExperimentConfigTests.cs | Checks Swift is outside experiment groups. |
| test/Microsoft.ComponentDetection.Detectors.Tests/ComponentDetectorTests.cs | Checks default-on status. |
| src/Microsoft.ComponentDetection.Orchestrator/Extensions/ServiceCollectionExtensions.cs | Removes Swift experiment registration. |
| src/Microsoft.ComponentDetection.Orchestrator/Experiments/Configs/SwiftDetectorExperiment.cs | Deletes retired experiment configuration. |
| src/Microsoft.ComponentDetection.Detectors/swiftpm/SwiftResolvedComponentDetector.cs | Removes experimental marker. |
| docs/detectors/swift.md | Documents default-on behavior. |
| docs/detectors/README.md | Marks Swift detection stable. |
Review effort: Balanced
Contributor
Author
|
Snapshot failures are expected, Swift being default-on means it's seeing Package.resolved for the first time. |
Aayush Maini (AMaini503)
approved these changes
Oct 19, 2026
Ryan Brandenburg (ryanbrandenburg)
merged commit Oct 20, 2026
73c64da
into
main
13 of 16 checks passed
Ryan Brandenburg (ryanbrandenburg)
deleted the
users/rybrande/SwiftDefaultOn
branch
October 20, 2026 15:49
|
👋 Hi! It looks like you modified some files in the
If none of the above scenarios apply, feel free to ignore this comment 🙂 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Everything looks good for Swift so we're looking to take it to Default-On.