Repository navigation
Install both our SDK and the one for Radarr - #1899
Merged
Ryan Brandenburg (ryanbrandenburg) merged 1 commit intoOct 16, 2026
Merged
Conversation
Ryan Brandenburg (ryanbrandenburg)
requested a review
from a team
as a code owner
October 16, 2026 22:27
Ryan Brandenburg (ryanbrandenburg)
requested a review
from Rushabh (RushabhBhansali)
October 16, 2026 22:27
Jamie Magee (JamieMagee)
approved these changes
Oct 16, 2026
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The setup step follows cloning, uses the correct manifest path, and preserves the existing SDK installation.
No open issues 🎉
What changed in this PR
Makes smoke tests resilient when Radarr requires a different .NET SDK from Component Detection.
Changes:
- Installs Radarr’s SDK from its cloned
global.jsonbefore restoring packages, while preserving the existing SDK setup.
| File | Description |
|---|---|
.github/workflows/smoke-test.yml |
Adds Radarr-specific .NET SDK setup before restore. |
Review effort: Balanced
Greg Villicana (grvillic)
approved these changes
Oct 16, 2026
Ryan Brandenburg (ryanbrandenburg)
deleted the
users/rybrande/SmokeTestSDK
branch
October 16, 2026 22:36
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We're getting failures on the smoke test because the example repo we build no longer just so happens to use the same SDK as us. This should make us resilient to them updating their global.json.