Skip to content

Add SwiftExperimentConfiguration - #1895

Merged
Ryan Brandenburg (ryanbrandenburg) merged 1 commit into
mainfrom
users/rybrande/SwiftExperimentConfiguration
Oct 14, 2026
Merged

Ryan Brandenburg (ryanbrandenburg) merged 1 commit into
mainfrom
users/rybrande/SwiftExperimentConfiguration

Conversation

@ryanbrandenburg

Copy link
Copy Markdown
Contributor

We've got this experiment but without the config it doesn't produce reports.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The focused configuration change fits existing experiment processing, with relevant tests and no blocking issues identified in static review.

0 open findings

What changed in this PR

Adds the missing Swift experiment configuration so existing experiment processing can produce reports for Swift discoveries.

Changes:

  • Registers Swift detection as an experiment with an empty control group.
  • Adds tests for registration, detector selection, and report processing.
  • Documents experiment activation and output behavior.
File Description
test/​Microsoft.ComponentDetection.Orchestrator.Tests/​Experiments/​SwiftDetectorExperimentTests.cs Tests experiment group selection and recording policy.
test/​Microsoft.ComponentDetection.Orchestrator.Tests/​Experiments/​ExperimentServiceTests.cs Tests Swift reporting and empty-result suppression.
test/​Microsoft.ComponentDetection.Orchestrator.Tests/​Experiments/​ExperimentConfigTests.cs Verifies Swift experiment registration.
src/​Microsoft.ComponentDetection.Orchestrator/​Extensions/​ServiceCollectionExtensions.cs Registers the experiment in dependency injection.
src/​Microsoft.ComponentDetection.Orchestrator/​Experiments/​Configs/​SwiftDetectorExperiment.cs Defines the Swift experiment configuration.
docs/​detectors/​swift.md Documents activation, reporting, and output behavior.

🧠 Review effort: Balanced


💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@ryanbrandenburg

Copy link
Copy Markdown
Contributor Author

@ryanbrandenburg
Ryan Brandenburg (ryanbrandenburg) merged commit cad465d into main Oct 14, 2026
14 of 19 checks passed
@ryanbrandenburg
Ryan Brandenburg (ryanbrandenburg) deleted the users/rybrande/SwiftExperimentConfiguration branch October 14, 2026 20:53
@github-actions

Copy link
Copy Markdown

👋 Hi! It looks like you modified some files in the Detectors folder.
You may need to bump the detector versions if any of the following scenarios apply:

  • The detector detects more or fewer components than before
  • The detector generates different parent/child graph relationships than before
  • The detector generates different devDependencies values than before

If none of the above scenarios apply, feel free to ignore this comment 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants