Repository navigation
Add SwiftExperimentConfiguration - #1895
Ryan Brandenburg (ryanbrandenburg) merged 1 commit into
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
The focused configuration change fits existing experiment processing, with relevant tests and no blocking issues identified in static review.
0 open findings
What changed in this PR
Adds the missing Swift experiment configuration so existing experiment processing can produce reports for Swift discoveries.
Changes:
- Registers Swift detection as an experiment with an empty control group.
- Adds tests for registration, detector selection, and report processing.
- Documents experiment activation and output behavior.
| File | Description |
|---|---|
| test/Microsoft.ComponentDetection.Orchestrator.Tests/Experiments/SwiftDetectorExperimentTests.cs | Tests experiment group selection and recording policy. |
| test/Microsoft.ComponentDetection.Orchestrator.Tests/Experiments/ExperimentServiceTests.cs | Tests Swift reporting and empty-result suppression. |
| test/Microsoft.ComponentDetection.Orchestrator.Tests/Experiments/ExperimentConfigTests.cs | Verifies Swift experiment registration. |
| src/Microsoft.ComponentDetection.Orchestrator/Extensions/ServiceCollectionExtensions.cs | Registers the experiment in dependency injection. |
| src/Microsoft.ComponentDetection.Orchestrator/Experiments/Configs/SwiftDetectorExperiment.cs | Defines the Swift experiment configuration. |
| docs/detectors/swift.md | Documents activation, reporting, and output behavior. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
https://github.com/microsoft/component-detection/blob/024e2a57ced73131f85f3659fb3ff49538fe8f9b/src/Microsoft.ComponentDetection.Orchestrator/Experiments/Configs/VcpkgExperiment.cs is an example of another experiment without a control group. |
cad465d
into
main
|
👋 Hi! It looks like you modified some files in the
If none of the above scenarios apply, feel free to ignore this comment 🙂 |
We've got this experiment but without the config it doesn't produce reports.