Observing iframe events in insights script - #822
Open
Muhammad AlAref (malaref) wants to merge 1 commit into
Open
Observing iframe events in insights script#822Muhammad AlAref (malaref) wants to merge 1 commit into
Muhammad AlAref (malaref) wants to merge 1 commit into
Conversation
nairmanu
approved these changes
Apr 30, 2025
nairmanu
reviewed
Apr 30, 2025
| const iframes = document.querySelectorAll("iframe"); | ||
| for (let i = 0; i < iframes.length; i++) { | ||
| const iframe = iframes[i]; | ||
| if (iframe.contentDocument) { |
Collaborator
There was a problem hiding this comment.
this can throw exception if iframe is cross origin so better to wrap it in try catch to avoid console errors
nairmanu
self-requested a review
April 30, 2025 23:57
nairmanu
reviewed
May 1, 2025
| for (let i = 0; i < iframes.length; i++) { | ||
| const iframe = iframes[i]; | ||
| if (iframe.contentDocument) { | ||
| getId(iframe.contentDocument.documentElement); // Pre-discover ID for iframe root |
Collaborator
There was a problem hiding this comment.
do we need to call getId?
nairmanu
requested changes
May 1, 2025
nairmanu
left a comment
nairmanu
left a comment
Collaborator
There was a problem hiding this comment.
pls check for potential errors esp in safari when accessing iframe.contentDocument
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.