dump kafka sample source from aspire repo#85
Draft
g7ed6e wants to merge 1 commit intomicrosoft:mainfrom
Draft
Conversation
eerhardt
added a commit
to microsoft/aspire
that referenced
this pull request
Jan 12, 2024
* Add Aspire.Confluent.Kafka component Contains APIs for both AddKafkaConsumer and AddKafkaProducer. As well as Kafka Hosting APIs to start a Kafka server container. Update ConfigurationSchema.json using ConfigSchemaGenerator. Cannot be automated until dotnet/runtime#96652 is fixed, so using a local temporary solution for now. Temporarily add Kafka OTel Metrics logic here until open-telemetry/opentelemetry-dotnet-contrib#1493 is available to use. Kafka sample can be found in microsoft/aspire-samples#85. * Address PR feedback - Make Kafka Settings Config object non-nullable and not settable from user code. - Use EventId 1 in Logging - Log response body in Functional tests * Adjust the initialization of the Settings Config properties because the type can be created publicly. Fix #884 --------- Co-authored-by: Eric Erhardt <eric.erhardt@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.