Draft
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request introduces a full stack Node.js solution integrated with a .NET Aspire host to demonstrate an end-to-end JavaScript solution with a Node.js API and a React frontend.
- Adds sample documentation describing the architecture and prerequisites.
- Configures the .NET Aspire host to run both the Node.js API and React app.
- Implements a simple Express API returning random weather forecast data and a corresponding React app that consumes it.
Reviewed Changes
Copilot reviewed 25 out of 25 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| samples/FullStackJS/README.md | Documentation introducing the full stack solution and its usage |
| samples/FullStackJS/FullStackJS.AppHost/Program.cs | Configuration of the .NET Aspire host and integration of Node apps |
| samples/FullStackJS/api/index.ts | Express API serving random weather data |
| samples/FullStackJS/app/webpack.config.js | Webpack configuration for the React app with proxy settings |
| samples/FullStackJS/app/src/index.js | Entry point for the React app |
| samples/FullStackJS/app/src/components/App.js | React component fetching and displaying weather forecast data |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
davidfowl
reviewed
Mar 11, 2025
davidfowl
reviewed
Mar 15, 2025
davidfowl
reviewed
Mar 15, 2025
| @@ -0,0 +1,22 @@ | |||
| FROM node:23-alpine as build | |||
Contributor
There was a problem hiding this comment.
We should look into optimizations we can do with node docker files. They are many.
Co-authored-by: David Fowler <davidfowl@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add full stack Node.js solution, this PR:
apiexpress-based Node.js app that serves random weather forecast data (much like the ASP.NET Core Minimal API template).appthat's copied from the existing React bits in the JavaScript samples.Contributes to dotnet/docs-aspire#2767